After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 693064 - meta-window-actor: Change unredirection hints to match spec changes
meta-window-actor: Change unredirection hints to match spec changes
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks:
 
 
Reported: 2013-02-02 19:07 UTC by drago01
Modified: 2013-02-03 13:30 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
meta-window-actor: Change unredirection hints to match spec changes (4.73 KB, patch)
2013-02-02 19:07 UTC, drago01 		needs-work Details | Review
meta-window-actor: Change unredirection hints to match spec changes (5.16 KB, patch)
2013-02-03 13:12 UTC, drago01 		committed Details | Review

Description drago01 2013-02-02 19:07:08 UTC 
We now have a final spec so adapt the code.
Comment 1 drago01 2013-02-02 19:07:10 UTC 
Created attachment 235072 [details] [review]
meta-window-actor: Change unredirection hints to match spec changes

Change the bypass / dont_bypass compositor code to match the latest
spec.
Comment 2 Jasper St. Pierre (not reading bugmail) 2013-02-03 11:33:44 UTC 
Review of attachment 235072 [details] [review]:

::: src/core/window.c
@@ +3657,3 @@
 meta_window_requested_bypass_compositor (MetaWindow *window)
 {
+  return window->bypass_compositor == 1;

Should we have:

typedef {
  _NET_WM_BYPASS_COMPOSITOR_HINT_AUTO = 0,
  _NET_WM_BYPASS_COMPOSITOR_HINT_ON = 1,
  _NET_WM_BYPASS_COMPOSITOR_HINT_OFF = 2,
} MetaBypassCompositorHintValue;
Comment 3 drago01 2013-02-03 13:12:42 UTC 
Created attachment 235104 [details] [review]
meta-window-actor: Change unredirection hints to match spec changes

Change the bypass / dont_bypass compositor code to match the latest
spec.
Comment 4 Jasper St. Pierre (not reading bugmail) 2013-02-03 13:14:43 UTC 
Review of attachment 235104 [details] [review]:

Much better.
Comment 5 drago01 2013-02-03 13:30:02 UTC 
Attachment 235104 [details] pushed as 9a57626 - meta-window-actor: Change unredirection hints to match spec changes