After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 693049 - volume: Suppress a critical warning
volume: Suppress a critical warning
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-02-02 10:31 UTC by Florian Müllner
Modified: 2013-02-05 00:07 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
volume: Suppress a critical warning (1.11 KB, patch)
2013-02-02 10:31 UTC, Florian Müllner 		committed Details | Review

Description Florian Müllner 2013-02-02 10:31:17 UTC 
Fix a harmless but annoying warning, see patch.
Comment 1 Florian Müllner 2013-02-02 10:31:21 UTC 
Created attachment 235056 [details] [review]
volume: Suppress a critical warning

gvc_mixer_stream_get_port() emits a warning in the no-ports case,
which we can avoid by rearranging the check for that case.
Comment 2 drago01 2013-02-02 22:59:15 UTC 
Review of attachment 235056 [details] [review]:

Looks good.
Comment 3 Florian Müllner 2013-02-04 11:43:04 UTC 
Attachment 235056 [details] pushed as d07c8dc - volume: Suppress a critical warning
Comment 4 Colin Walters 2013-02-05 00:07:33 UTC 
Thanks for fixing this, one fewer g_critical when booting gnome-ostree in qemu's default config.  Slowly trending towards zero...