After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 693030 - Don't ask Xlib to skip ARGB visuals
Don't ask Xlib to skip ARGB visuals
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: General
unspecified
Other All
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-02-01 19:19 UTC by Giovanni Campagna
Modified: 2013-02-05 21:46 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Don't ask Xlib to skip ARGB visuals (998 bytes, patch)
2013-02-01 19:19 UTC, Giovanni Campagna 		committed Details | Review

Description Giovanni Campagna 2013-02-01 19:19:51 UTC 
Fixes a crash with backtrace:

(gdb) bt
    at gdkdisplay-x11.c:928
    at gdkeventtranslator.c:51
    at gdkeventsource.c:354
    rtld_fini=<optimized out>, stack_end=0x7fff10a3a108) at libc-start.c:225

The window (0x4400021) is not one created by epiphany / the UI layer of WebKit2
(the XID range is different), therefore I assume it is created by WebCore::GLXSurface(),
which explains why it gets an ARGB visual even if libX11 reports none.
Comment 1 Giovanni Campagna 2013-02-01 19:19:56 UTC 
Created attachment 235026 [details] [review]
Don't ask Xlib to skip ARGB visuals

WebKit uses GLX windows internally, which will have alpha. If any
of those windows receives an event, Gtk will attempt to create a
foreign GdkWindow wrapping them, and will crash because XGetWindowAttributes
will return a NULL visual.
Comment 2 Xan Lopez 2013-02-05 21:34:09 UTC 
Review of attachment 235026 [details] [review]:

OK. I did a quick grep in chrome/firefox and I don't see them doing this anymore, so I guess it's not even useful anymore.
Comment 3 Giovanni Campagna 2013-02-05 21:46:54 UTC 
Attachment 235026 [details] pushed as 8b63fec - Don't ask Xlib to skip ARGB visuals