After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 692988 - ev-view: call gtk_style_context_set_background()
ev-view: call gtk_style_context_set_background()
Status: RESOLVED FIXED
Product: evince
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Evince Maintainers
Evince Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-02-01 10:28 UTC by Cosimo Cecchi
Modified: 2013-02-02 13:58 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
ev-view: call gtk_style_context_set_background() (1.11 KB, patch)
2013-02-01 10:28 UTC, Cosimo Cecchi
committed Details | Review

Description Cosimo Cecchi 2013-02-01 10:28:37 UTC
See commit message for the rationale; this makes a huge difference in gnome-documents.
Comment 1 Cosimo Cecchi 2013-02-01 10:28:39 UTC
Created attachment 234954 [details] [review]
ev-view: call gtk_style_context_set_background()

Even if we now render a background in _draw() with
gtk_render_background, using gtk_style_context_set_background() in
realize makes the backing GdkWindow not being completely transparent,
which enables GTK to apply optimizations during the paint cycle.
The result is, especially in clutter-gtk applications such as Documents,
scrolling in a document page is much smoother.
Comment 2 Germán Poo-Caamaño 2013-02-01 10:49:31 UTC
Can this be related to https://bugzilla.gnome.org/show_bug.cgi?id=691448 ?
Comment 3 Cosimo Cecchi 2013-02-01 10:58:39 UTC
This shouldn't affect the thumbnails view, no.
Comment 4 Carlos Garcia Campos 2013-02-02 13:58:10 UTC
Comment on attachment 234954 [details] [review]
ev-view: call gtk_style_context_set_background()

Pushed, thank you very much