GNOME Bugzilla – Bug 692928
Document G_MENU_{ATTRIBUTE,LINK}_*
Last modified: 2013-02-03 14:58:53 UTC
Also attached is a patch that fixes a typo and one that documents G_MENU_ATTRIBUTE_ACTION_NAMESPACE.
Created attachment 234894 [details] [review] gmenuexporter: fix typo in docstring
Created attachment 234895 [details] [review] gmenumodel: document G_MENU_{ATTRIBUTE,LINK}_*
Created attachment 234896 [details] [review] gmenumodel: add G_MENU_ATTRIBUTE_ACTION_NAMESPACE
Review of attachment 234894 [details] [review]: sure
Review of attachment 234895 [details] [review]: ok
Review of attachment 234896 [details] [review]: ::: gio/gmenumodel.h @@ +52,3 @@ + **/ +#define G_MENU_ATTRIBUTE_ACTION "action-namespace" + There's a mismatch here...
Created attachment 234912 [details] [review] Oops. Thanks for the quick review.
Review of attachment 234912 [details] [review]: ::: gio/gmenumodel.h @@ +49,3 @@ + * menus that are linked from this item. + * + * Since: 2.32 I think the 2.32 is probably wrong here ? Its a little tricky, since these attributes are not actually used in gio at all. Lets just go with 2.36, I'd say. Thats correct for the macro, at least
Created attachment 235003 [details] [review] gmenumodel: add G_MENU_ATTRIBUTE_ACTION_NAMESPACE Hm, two copy and paste errors in a ten-line patch. Thanks.
Review of attachment 235003 [details] [review]: ok now
Attachment 234894 [details] pushed as aeafab1 - gmenuexporter: fix typo in docstring Attachment 234895 [details] pushed as 7fb9223 - gmenumodel: document G_MENU_{ATTRIBUTE,LINK}_* Attachment 235003 [details] pushed as 1a7b4b4 - gmenumodel: add G_MENU_ATTRIBUTE_ACTION_NAMESPACE