After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 692896 - sharing: make distcheck fails
sharing: make distcheck fails
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Sharing
git master
Other Linux
: Normal critical
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-01-30 20:19 UTC by Jeremy Bicha
Modified: 2013-01-31 09:21 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
buildlog (110.39 KB, text/plain)
2013-01-30 20:19 UTC, Jeremy Bicha 		  Details
sharing-Fix-make-distcheck (1.62 KB, patch)
2013-01-30 22:30 UTC, Rico Tzschichholz 		committed Details | Review
network: fix make distcheck (5.28 KB, patch)
2013-01-31 00:14 UTC, darkxst 		accepted-commit_now Details | Review
network: fix make distcheck (1.62 KB, patch)
2013-01-31 08:46 UTC, darkxst 		committed Details | Review

Description Jeremy Bicha 2013-01-30 20:19:03 UTC 
Created attachment 234851 [details]
buildlog

I can't get make distcheck to work for gnome-control-center master. Full log attached. I also get the same remote login policy error if I just do make check and try to build the resulting tarball for Ubuntu.

panels/sharing/sharing.gresource.xml: Error on line 5 char 1: Failed to locate 'sharing.ui' in current directory.

make[5]: *** No rule to make target `org.gnome.controlcenter.remote-login-helper.policy.in.in', needed by `org.gnome.controlcenter.remote-login-helper.policy.in'.  Stop.
Comment 1 Rico Tzschichholz 2013-01-30 22:30:35 UTC 
Created attachment 234874 [details] [review]
sharing-Fix-make-distcheck
Comment 2 Matthias Clasen 2013-01-30 23:08:14 UTC 
Review of attachment 234874 [details] [review]:

looks right
Comment 3 darkxst 2013-01-31 00:14:00 UTC 
Created attachment 234876 [details] [review]
network: fix make distcheck
Comment 4 Bastien Nocera 2013-01-31 06:51:20 UTC 
Review of attachment 234874 [details] [review]:

::: po/POTFILES.skip
@@ +16,3 @@
 panels/search/gnome-search-panel.desktop.in
 panels/sharing/gnome-sharing-panel.desktop.in
+panels/sharing/org.gnome.controlcenter.remote-login-helper.policy.in

That's not the correct file.
Comment 5 Bastien Nocera 2013-01-31 06:53:04 UTC 
Review of attachment 234876 [details] [review]:

++
Comment 6 Rico Tzschichholz 2013-01-31 08:23:21 UTC 
(In reply to comment #4)
> Review of attachment 234874 [details] [review]:
> 
> ::: po/POTFILES.skip
> @@ +16,3 @@
>  panels/search/gnome-search-panel.desktop.in
>  panels/sharing/gnome-sharing-panel.desktop.in
> +panels/sharing/org.gnome.controlcenter.remote-login-helper.policy.in
> 
> That's not the correct file.

It is, the *.in.in file is added to POTFILES.in
Comment 7 Bastien Nocera 2013-01-31 08:31:07 UTC 
Review of attachment 234874 [details] [review]:

The .in.in is in POTFILES.in
Comment 8 darkxst 2013-01-31 08:46:44 UTC 
Created attachment 234889 [details] [review]
network: fix make distcheck
Comment 9 Rico Tzschichholz 2013-01-31 08:49:51 UTC 
Review of attachment 234889 [details] [review]:

+1
Comment 10 Rico Tzschichholz 2013-01-31 09:02:06 UTC 
Review of attachment 234889 [details] [review]:

commit 3c0af77abb741608c9d1032b1c4cb288ce697113
Author: Tim Lunn <tim@feathertop.org>
Date:   Thu Jan 31 10:26:06 2013 +1100

    network: fix make distcheck
Comment 11 Rico Tzschichholz 2013-01-31 09:02:20 UTC 
Review of attachment 234874 [details] [review]:

commit c07eb16bc56042bdde74fb3dac15a28e5b61eb80
Author: Rico Tzschichholz <ricotz@t-online.de>
Date:   Wed Jan 30 23:27:38 2013 +0100

    sharing: Fix make distcheck