After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 692768 - [PATCH] support notification filtering
[PATCH] support notification filtering
Product: gnome-online-accounts
Classification: Core
Component: general
Other Linux
: Normal enhancement
: ---
Assigned To: GNOME Online Accounts maintainer(s)
GNOME Online Accounts maintainer(s)
Depends on:
Blocks: 690985
Reported: 2013-01-29 07:02 UTC by Nuno Araujo (IRC: russo79)
Modified: 2013-01-29 16:21 UTC
See Also:
GNOME target: ---
GNOME version: ---

Support notification filtering (3.23 KB, patch)
2013-01-29 07:04 UTC, Nuno Araujo (IRC: russo79)
reviewed Details | Review
Support notification filtering (3.30 KB, patch)
2013-01-29 16:07 UTC, Debarshi Ray
none Details | Review
Support notification filtering (3.71 KB, patch)
2013-01-29 16:19 UTC, Debarshi Ray
committed Details | Review

Description Nuno Araujo (IRC: russo79) 2013-01-29 07:02:23 UTC
Comment 1 Nuno Araujo (IRC: russo79) 2013-01-29 07:04:41 UTC
Created attachment 234700 [details] [review]
Support notification filtering

Set the desktop-entry hint on the notifications of goa-daemon and
create a desktop file for it with a X-GNOME-UsesNotifications key, so
that it appears in the new control panel notifications panel.
Comment 2 Debarshi Ray 2013-01-29 16:06:44 UTC
Comment on attachment 234700 [details] [review]
Support notification filtering

Thanks for the patch.

A few comments:
- I think the desktop file should be named goa-daemon, instead of goadaemon.
- notify_notification_set_hint_string is deprecated, so we should use notify_notification_set_hint
- We should drop the "Daemon" from the Name in the desktop file. Not sure if we should retain "GNOME" too or not.
Comment 3 Debarshi Ray 2013-01-29 16:07:43 UTC
Created attachment 234762 [details] [review]
Support notification filtering

Here is a patch with the above changes.
Comment 4 Debarshi Ray 2013-01-29 16:19:59 UTC
Created attachment 234764 [details] [review]
Support notification filtering

Lets get rid of the "GNOME" too.

From #gnome-design
16:08 <rishi> Re: , I am      
      wondering if it should show up as "GNOME Online Accounts" or "Online      
      Accounts" in the notifications panel.
16:09 <hadess> rishi, online accounts
16:09 <hadess> rishi, repeating the GNOME isn't too helpful when you're         
      already in GNOME
Comment 5 Debarshi Ray 2013-01-29 16:20:51 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.