After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 692766 - textlayout: respect preedit color attribute
textlayout: respect preedit color attribute
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2013-01-29 06:06 UTC by Daiki Ueno
Modified: 2013-01-31 02:27 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
textlayout: respect preedit color attribute (1.90 KB, patch)
2013-01-29 06:06 UTC, Daiki Ueno 		needs-work Details | Review
textlayout: respect preedit color attribute (1.93 KB, patch)
2013-01-30 02:02 UTC, Daiki Ueno 		committed Details | Review

Description Daiki Ueno 2013-01-29 06:06:29 UTC 
Since GTK3, the background/foreground attributes of IM preedit text are ignored on GtkTextView, not on GtkEntry.

Test case:
1. enable ibus-anthy on "Entry Buffer" example on gtk3-demo
2. type "kyouhaiitenkidesu" and then space
3. you will see the whole preedit is underlined and the first 3 Japanese letters are with cyan background
4. do 1, 2, 3 on bloatpad
5. you will see only underline

This looks like a leftover of recent GdkColor -> GdkRGBA migration.
Comment 1 Daiki Ueno 2013-01-29 06:06:31 UTC 
Created attachment 234698 [details] [review]
textlayout: respect preedit color attribute

gtk_text_renderer_prepare_run now checks appearance.rgba, rather than
appearance.{fg_color,bg_color}.
Comment 2 Matthias Clasen 2013-01-29 12:19:30 UTC 
Review of attachment 234698 [details] [review]:

I think you should just fix convert_color to set the rgba directly
Comment 3 Daiki Ueno 2013-01-30 02:02:17 UTC 
Created attachment 234790 [details] [review]
textlayout: respect preedit color attribute

gtk_text_renderer_prepare_run now checks appearance.rgba, rather than
appearance.{fg_color,bg_color}.
--
Thanks, done.
Comment 4 Matthias Clasen 2013-01-30 17:36:51 UTC 
Review of attachment 234790 [details] [review]:

thanks, looks good to me
Comment 5 Daiki Ueno 2013-01-31 02:27:42 UTC 
Attachment 234790 [details] pushed as 7a9553c - textlayout: respect preedit color attribute