After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 692741 - Fixes for the resize window popup
Fixes for the resize window popup
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks:
 
 
Reported: 2013-01-28 21:49 UTC by Cosimo Cecchi
Modified: 2013-02-10 19:26 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
resize-popup: don't use a GtkFrame (1.43 KB, patch)
2013-01-28 21:50 UTC, Cosimo Cecchi 		committed Details | Review
resize-popup: set a bigger margin (1008 bytes, patch)
2013-01-28 21:50 UTC, Cosimo Cecchi 		committed Details | Review
resize-popup: use a tooltip style for the resize popup window (2.76 KB, patch)
2013-01-28 21:50 UTC, Cosimo Cecchi 		committed Details | Review

Description Cosimo Cecchi 2013-01-28 21:49:58 UTC 
It doesn't currently look like a GtkTooltip; attached patchset fixes that.
Comment 1 Cosimo Cecchi 2013-01-28 21:50:00 UTC 
Created attachment 234661 [details] [review]
resize-popup: don't use a GtkFrame

We want this to look like a normal tooltip - start with removing the
GtkFrame around its shape.
Comment 2 Cosimo Cecchi 2013-01-28 21:50:04 UTC 
Created attachment 234662 [details] [review]
resize-popup: set a bigger margin

Since we're going to use the tooltip's rounded corners we need a little
bit more of margin (which wasn't a bad idea even with the frame).
Also, don't use GtkMisc for this anymore.
Comment 3 Cosimo Cecchi 2013-01-28 21:50:06 UTC 
Created attachment 234663 [details] [review]
resize-popup: use a tooltip style for the resize popup window

- set GTK_STYLE_CLASS_TOOLTIP on the window, and use the same code of
  GtkTooltip to paint it
- set GDK_WINDOW_TYPE_HINT_TOOLTIP and make the window non-resizable, so
  it doesn't get an incorrect shadow from the WM
Comment 4 drago01 2013-02-04 08:25:15 UTC 
Review of attachment 234661 [details] [review]:

Looks good.
Comment 5 drago01 2013-02-04 08:25:44 UTC 
Review of attachment 234662 [details] [review]:

OK.
Comment 6 drago01 2013-02-04 08:27:41 UTC 
Review of attachment 234663 [details] [review]:

Looks good.
Comment 7 Cosimo Cecchi 2013-02-10 19:26:02 UTC 
Attachment 234661 [details] pushed as c3ffd28 - resize-popup: don't use a GtkFrame
Attachment 234662 [details] pushed as 34fc234 - resize-popup: set a bigger margin
Attachment 234663 [details] pushed as 94e6e55 - resize-popup: use a tooltip style for the resize popup window