GNOME Bugzilla – Bug 692733
move from /var/run to /run, in accordance with systemd design principle
Last modified: 2013-02-20 16:25:27 UTC
Using systemd, we're supposed to occupy /run instead of /var/run. Thus, changing the defaults sounds sane.
Created attachment 234652 [details] [review] Move from /var/run to /run
sure, thanks.
I had to revert this. it breaks distcheck, and it's not immediately apparent to me why.
May I suggest having a --with-run-dir configure option, or something? For historical reasons[1], Debian uses [/var]/run/gdm3 instead of just gdm. [1] for a while we supported both gdm (gdm 2) and gdm3, while Gdm 3 caught up with Gdm 2's feature set; these days we only have Gdm 3
Created attachment 235436 [details] [review] Add a --with-run-dir which sets the default for everything in [/var]/run Distributions that don't like /var/run can override this to /run/gdm; distributions where the directory differs (like Debian, which uses /run/gdm3) can override this and it'll affect everything.
this suffers from the same issue. make uninstall ends up deleting outside of DESTDIR. We probably could just drop the hooks where we create and destroy the directories at build time, since gdm now creates them at run time.
(In reply to comment #6) > this suffers from the same issue. make uninstall ends up deleting outside of > DESTDIR. I believe this only applies if you change the default to be something not starting with ${prefix}. make distcheck uses default settings (unless you change them in DISTCHECK_CONFIGURE_FLAGS) so if you leave the default as ${localstatedir}/run/gdm, as my patch does, it should be fine? (You could even set the default to /run/gdm, and put --with-run-dir='${localstatedir}/run/gdm' in DISTCHECK_CONFIGURE_FLAGS.) > We probably could just drop the hooks where we create and destroy the > directories at build time, since gdm now creates them at run time. Creating: yes, I think that would be reasonable. /run will be empty after each reboot anyway. For deleting I'm not sure, it does seem a bit wrong if `make uninstall` leaves droppings behind (even in a transient directory)?
okay i'll push this.