After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 692679 - Make some mutter calls public
Make some mutter calls public
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks: 692680
 
 
Reported: 2013-01-28 06:56 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2013-02-06 05:04 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
screen: Add wrappers for monitor calculation functions (2.17 KB, patch)
2013-01-28 06:56 UTC, Jasper St. Pierre (not reading bugmail) 		reviewed Details | Review
Make work_area calculation funcs public and introspectible (6.55 KB, patch)
2013-01-28 06:56 UTC, Jasper St. Pierre (not reading bugmail) 		accepted-commit_now Details | Review
screen: Add an introspectible wrapper for find_monitor_for_rect (1.78 KB, patch)
2013-01-28 19:50 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review

Description Jasper St. Pierre (not reading bugmail) 2013-01-28 06:56:51 UTC 
See patches. This can clean up some very similar code in the Shell.
Comment 1 Jasper St. Pierre (not reading bugmail) 2013-01-28 06:56:53 UTC 
Created attachment 234590 [details] [review]
screen: Add wrappers for monitor calculation functions

That return a monitor index, so that they're introspectible
Comment 2 Jasper St. Pierre (not reading bugmail) 2013-01-28 06:56:56 UTC 
Created attachment 234591 [details] [review]
Make work_area calculation funcs public and introspectible
Comment 3 Giovanni Campagna 2013-01-28 08:47:25 UTC 
Review of attachment 234590 [details] [review]:

::: src/core/screen.c
@@ +2058,3 @@
+int
+meta_screen_get_monitor_index_for_window (MetaScreen *screen,
+  const MetaMonitorInfo *monitor = meta_screen_get_monitor_for_rect (screen, rect);

You don't need this, you can use meta_window_get_monitor()
Comment 4 Giovanni Campagna 2013-01-28 08:47:55 UTC 
Review of attachment 234591 [details] [review]:

Yes.
Comment 5 Jasper St. Pierre (not reading bugmail) 2013-01-28 19:50:29 UTC 
Created attachment 234648 [details] [review]
screen: Add an introspectible wrapper for find_monitor_for_rect

Instead of returning a MonitorInfo, it returns a monitor index.
Comment 6 Giovanni Campagna 2013-01-28 20:11:55 UTC 
Review of attachment 234648 [details] [review]:

Ok
Comment 7 Jasper St. Pierre (not reading bugmail) 2013-02-06 05:04:43 UTC 
Attachment 234648 [details] pushed as 32b7743 - screen: Add an introspectible wrapper for find_monitor_for_rect