After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 692638 - Don't use AC_CANONICAL_TARGET
Don't use AC_CANONICAL_TARGET
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
3.7.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2013-01-27 14:50 UTC by Erik van Pienbroek
Modified: 2013-06-02 09:11 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch (1.10 KB, patch)
2013-01-27 14:50 UTC, Erik van Pienbroek 		committed Details | Review
0001-Do-not-use-AC_CANONICAL_TARGET.patch (1.32 KB, patch)
2013-04-01 10:43 UTC, Hib Eris 		committed Details | Review

Description Erik van Pienbroek 2013-01-27 14:50:44 UTC 
Created attachment 234533 [details] [review]
Proposed patch

This autoconf macro should only be used for building compilers
(or compiler tools) for a specific target. The current effect of
it in GTK3 is that it causes various executables like gtk3-demo
to be prefixed with $target- when the --target configure flag
is set or when cross-compiling. When cross-compiling GTK3 on
Linux for the Win32 target this causes the gtk3-demo binary
to be named i686-w64-mingw32-gtk3-demo.exe instead of just
gtk3-demo.exe (like it was before commit 53083ea7b423482b)

See also http://blog.flameeyes.eu/2008/10/you-dont-want-to-canonicalise-that-and-im-not-referring-to-ubuntu and http://blog.flameeyes.eu/2009/01/the-canonical-target for more information about this subject
Comment 1 Hib Eris 2013-04-01 09:42:40 UTC 
Reopening, the fix for this was reverted by commit 717c28e12daff5ae9fcb01b45cd1daf13609cddb
Comment 2 Hib Eris 2013-04-01 10:43:32 UTC 
Created attachment 240295 [details] [review]
0001-Do-not-use-AC_CANONICAL_TARGET.patch
Comment 3 Hib Eris 2013-04-01 10:44:43 UTC 
Review of attachment 234533 [details] [review]:

This patch was committed but regrettably reverted again later.
Comment 4 Hib Eris 2013-04-30 13:38:33 UTC 
Matthias, can you review attachment 240295 [details] [review]. It fixes the issue that triggered you to revert the fix for this issue with commit 717c28e12daff5ae9fcb01b45cd1daf13609cddb
Comment 5 Matthias Clasen 2013-05-13 18:35:50 UTC 
Not sure I entirely understand it: You remove AC_CANONICAL_TARGET from configure.ac, but you add a prereq for AC_CANONICAL_HOST - typo ?
Comment 6 Hib Eris 2013-05-13 18:43:09 UTC 
(In reply to comment #5)
> Not sure I entirely understand it: You remove AC_CANONICAL_TARGET from
> configure.ac, but you add a prereq for AC_CANONICAL_HOST - typo ?

No, not a typo. I remove AC_CANONICAL_TARGET basically because GTK is not a compiler and thus has no target (as explained in the original bug report).

Then, in ax_prog_cc_for_build.m4 I do:

-AC_REQUIRE([AC_CANONICAL_SYSTEM])dnl
+AC_REQUIRE([AC_CANONICAL_HOST])dnl

The AC_CANONICAL_SYSTEM was also checking for the target system which is unneeded for the purpose of prog_cc_for_build. It is replaced by AC_CANONICAL_HOST, which only checks for the host system, not for the target system.
Comment 7 Hib Eris 2013-06-02 09:11:24 UTC 
Attachment 240295 [details] pushed as f59c482 - Do not use AC_CANONICAL_TARGET