After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 692565 - moduleset: Add modules required to build with js17
moduleset: Add modules required to build with js17
Status: RESOLVED FIXED
Product: jhbuild
Classification: Infrastructure
Component: module sets
unspecified
Other All
: Normal normal
: ---
Assigned To: Jhbuild maintainers
Jhbuild QA
Depends on:
Blocks: 690982
 
 
Reported: 2013-01-25 23:07 UTC by darkxst
Modified: 2013-03-26 20:56 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
moduleset: Add modules required to build with js188 (45.21 KB, patch)
2013-01-25 23:07 UTC, darkxst
none Details | Review
fix undefined marcos in JS188 (920 bytes, patch)
2013-01-30 19:58 UTC, darkxst
none Details | Review
moduleset: Add module for new Spidermonkey 17esr engine (3.31 KB, patch)
2013-03-03 21:22 UTC, darkxst
none Details | Review
moduleset: Add module for new Spidermonkey 17esr engine (3.41 KB, patch)
2013-03-03 21:48 UTC, darkxst
committed Details | Review
modulest: fix spidermonkey hash (1.12 KB, patch)
2013-03-16 03:07 UTC, darkxst
accepted-commit_now Details | Review
moduleset: update for spidermonkey 17 release (1.77 KB, patch)
2013-03-25 21:12 UTC, darkxst
committed Details | Review

Description darkxst 2013-01-25 23:07:03 UTC
This adds the modules required to build gjs/g-s against spidermonkey
esr17/js188. Currently as a sperate module set, so can just override
the required modules from the main moduleset.
Comment 1 darkxst 2013-01-25 23:07:05 UTC
Created attachment 234451 [details] [review]
moduleset: Add modules required to build with js188
Comment 2 darkxst 2013-01-30 19:58:48 UTC
Created attachment 234850 [details] [review]
fix undefined marcos in JS188

This is a small patch that needs to be applied to the 'spidermonkey-as-git' repo, so that gjs will build without complaining about missing UINT32_MAX macro.
Comment 3 Frederic Peters 2013-01-30 20:05:22 UTC
As it looks like it's just for testing I'd suggest you to simply publish the moduleset somewhere; jhbuild is able to fetch them over http. Or am I missing something?
Comment 4 darkxst 2013-01-30 20:21:20 UTC
ok, have put it here.
http://www.feathertop.org/mozjs188.modules
Comment 5 darkxst 2013-03-03 21:22:04 UTC
Created attachment 237906 [details] [review]
moduleset: Add module for new Spidermonkey 17esr engine

This is the RC release of the new spidermonkey engine. This is in preparation
for providing an official gjs branch against this engine.
Comment 6 Frederic Peters 2013-03-03 21:32:03 UTC
This says version="1.0.0" but the actual version is a bit different, as it's just a release candidate at the moment; could you change the version string to accomodate that?  (also it would be nice if you added tarball checksums)
Comment 7 darkxst 2013-03-03 21:48:51 UTC
Created attachment 237909 [details] [review]
moduleset: Add module for new Spidermonkey 17esr engine
Comment 8 Frederic Peters 2013-03-04 07:40:50 UTC
Looks fine to me; commit this whenever the gjs build dependency is changed.
Comment 9 Colin Walters 2013-03-10 20:06:54 UTC
One thing we need to get fixed upstream is to honor --disable-static.

-rwxr-xr-x. 1 walters walters 248M Mar 10 12:53 /src/build/jhbuild/lib64/libmozjs-17.0.a

No one should be linking the static library, and 248M is enormous!  We don't want downstreams to be redistributing that.
Comment 10 Colin Walters 2013-03-10 20:08:59 UTC
Hm, also the fact that the two libraries only parallel install runtime and not headers is problematic.
Comment 11 Colin Walters 2013-03-12 14:52:06 UTC
Review of attachment 237909 [details] [review]:

So this looks safe to add now.  jhbuild doesn't have any concept of optional build dependencies, so we can just tell people who want to test gjs+js17 to switch their gjs branch.
Comment 12 darkxst 2013-03-12 21:01:24 UTC
Comment on attachment 237909 [details] [review]
moduleset: Add module for new Spidermonkey 17esr engine

Attachment 237909 [details] pushed as 3fca772 - moduleset: Add module for new Spidermonkey 17esr engine
Comment 13 darkxst 2013-03-16 03:07:18 UTC
Created attachment 239017 [details] [review]
modulest: fix spidermonkey hash

cut + paste fail...
Comment 14 Colin Walters 2013-03-16 13:30:12 UTC
Review of attachment 239017 [details] [review]:

Sure.
Comment 15 darkxst 2013-03-25 21:12:53 UTC
Created attachment 239832 [details] [review]
moduleset: update for spidermonkey 17 release
Comment 16 darkxst 2013-03-26 20:56:13 UTC
Attachment 239832 [details] pushed as 462e172 - moduleset: update for spidermonkey 17 release