GNOME Bugzilla – Bug 692565
moduleset: Add modules required to build with js17
Last modified: 2013-03-26 20:56:18 UTC
This adds the modules required to build gjs/g-s against spidermonkey esr17/js188. Currently as a sperate module set, so can just override the required modules from the main moduleset.
Created attachment 234451 [details] [review] moduleset: Add modules required to build with js188
Created attachment 234850 [details] [review] fix undefined marcos in JS188 This is a small patch that needs to be applied to the 'spidermonkey-as-git' repo, so that gjs will build without complaining about missing UINT32_MAX macro.
As it looks like it's just for testing I'd suggest you to simply publish the moduleset somewhere; jhbuild is able to fetch them over http. Or am I missing something?
ok, have put it here. http://www.feathertop.org/mozjs188.modules
Created attachment 237906 [details] [review] moduleset: Add module for new Spidermonkey 17esr engine This is the RC release of the new spidermonkey engine. This is in preparation for providing an official gjs branch against this engine.
This says version="1.0.0" but the actual version is a bit different, as it's just a release candidate at the moment; could you change the version string to accomodate that? (also it would be nice if you added tarball checksums)
Created attachment 237909 [details] [review] moduleset: Add module for new Spidermonkey 17esr engine
Looks fine to me; commit this whenever the gjs build dependency is changed.
One thing we need to get fixed upstream is to honor --disable-static. -rwxr-xr-x. 1 walters walters 248M Mar 10 12:53 /src/build/jhbuild/lib64/libmozjs-17.0.a No one should be linking the static library, and 248M is enormous! We don't want downstreams to be redistributing that.
Hm, also the fact that the two libraries only parallel install runtime and not headers is problematic.
Review of attachment 237909 [details] [review]: So this looks safe to add now. jhbuild doesn't have any concept of optional build dependencies, so we can just tell people who want to test gjs+js17 to switch their gjs branch.
Comment on attachment 237909 [details] [review] moduleset: Add module for new Spidermonkey 17esr engine Attachment 237909 [details] pushed as 3fca772 - moduleset: Add module for new Spidermonkey 17esr engine
Created attachment 239017 [details] [review] modulest: fix spidermonkey hash cut + paste fail...
Review of attachment 239017 [details] [review]: Sure.
Created attachment 239832 [details] [review] moduleset: update for spidermonkey 17 release
Attachment 239832 [details] pushed as 462e172 - moduleset: update for spidermonkey 17 release