After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 692521 - do not use dark theme for fullscreen view
do not use dark theme for fullscreen view
Status: RESOLVED FIXED
Product: gnome-documents
Classification: Core
Component: general
3.7.x
Other Linux
: Normal normal
: ---
Assigned To: GNOME documents maintainer(s)
GNOME documents maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-01-25 12:32 UTC by Jakub Steiner
Modified: 2013-01-29 18:41 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Don't use dark theme in fullscreen (826 bytes, patch)
2013-01-29 09:38 UTC, William Jon McCann
committed Details | Review

Description Jakub Steiner 2013-01-25 12:32:03 UTC
When running Documents maximized, it switches chrome to use the dark theme when viewing a document. While it sounds appropriate in theory, the fact that most documents are mostly white, creates a very contrasty situation. 

The light documents actually might look better just using a default light theme even for fullscreen. Alternatively, things might work better if the backdrop was completely black and the overlay toolbar used the .osd style (ala recent Boxes).
Comment 1 William Jon McCann 2013-01-25 19:36:28 UTC
One option is to have separate fullscreen and presentation modes.
Comment 2 William Jon McCann 2013-01-29 09:38:20 UTC
Created attachment 234709 [details] [review]
Don't use dark theme in fullscreen

It is a bit drastic to change themes between maximized and fullscreen.
Comment 3 Cosimo Cecchi 2013-01-29 11:28:16 UTC
Review of attachment 234709 [details] [review]:

OK