GNOME Bugzilla – Bug 692495
Background image select button is below screen bottom on small screen
Last modified: 2014-06-16 13:26:47 UTC
Created attachment 234360 [details] select button is below the screen bottom Background image select button is below screen bottom on small screen
confirmed issue on acer Aspire 1410 (resolution is 1024x600) Ok I know there are other ways to set a picture as wallpaper.. :-) , but the "standard" should be usable also with low screen resolutions Cheers Andrea
This code is supposed to make the chooser smaller than the control-center shell: http://git.gnome.org/browse/gnome-control-center/tree/panels/background/cc-background-chooser-dialog.c?h=gnome-3-6#n90
But then, it does that: http://git.gnome.org/browse/gnome-control-center/tree/panels/background/cc-background-chooser-dialog.c?h=gnome-3-6#n259 I think we should check if the parent is maximised, and then maximise this window as well so the majority of the screen is taken up by the background selection.
*** Bug 689553 has been marked as a duplicate of this bug. ***
*** Bug 706919 has been marked as a duplicate of this bug. ***
*** Bug 719374 has been marked as a duplicate of this bug. ***
*** Bug 727308 has been marked as a duplicate of this bug. ***
commit 130dd418b83a98c2f42343ef56862488daf2509c Author: Bastien Nocera <hadess@hadess.net> Date: Mon Apr 14 11:33:01 2014 +0200 background: Make whole dialog visible on small screens When using a small screen, make sure that the whole of the dialogue is visible, including the confirmation buttons. This means that the dialogue will be maximised when on smaller screens (just like its parent), and that we won't set a number of columns for the icon view. We will also stop making the dialogue much bigger than the Settings window itself. https://bugzilla.gnome.org/show_bug.cgi?id=692495
(In reply to comment #8) > commit 130dd418b83a98c2f42343ef56862488daf2509c > Author: Bastien Nocera <hadess@hadess.net> > Date: Mon Apr 14 11:33:01 2014 +0200 > > background: Make whole dialog visible on small screens Unfortunately, this broke the test program.
Created attachment 278538 [details] [review] background: Unbreak the test program
Review of attachment 278538 [details] [review]: Fine by me.