After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 692481 - gtkimage: Add GtkImage::resource property
gtkimage: Add GtkImage::resource property
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2013-01-24 22:31 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2013-01-24 22:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gtkimage: Add GtkImage::resource property (3.95 KB, patch)
2013-01-24 22:31 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review

Description Jasper St. Pierre (not reading bugmail) 2013-01-24 22:31:45 UTC 
This is designed for GtkBuilder scenarios:

    <object class="GtkImage" id="blah">
        <property name="resource">/org/myapp/blah.png</property>
    </object>
Comment 1 Jasper St. Pierre (not reading bugmail) 2013-01-24 22:31:47 UTC 
Created attachment 234341 [details] [review]
gtkimage: Add GtkImage::resource property
Comment 2 Cosimo Cecchi 2013-01-24 22:35:11 UTC 
Review of attachment 234341 [details] [review]:

Looks good to me, except for this.

::: gtk/gtkimage.c
@@ +489,3 @@
       break;
+    case PROP_RESOURCE:
+      gtk_image_set_from_resource (image, g_value_get_string (value));

Should g_value_set_string (value, priv->resource_path);
Comment 3 Jasper St. Pierre (not reading bugmail) 2013-01-24 22:47:55 UTC 
Attachment 234341 [details] pushed as 86f024b - gtkimage: Add GtkImage::resource property


Oops. Fixed and pushed.