After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 692466 - clutter: Add "support" for XI2.3
clutter: Add "support" for XI2.3
Status: RESOLVED FIXED
Product: clutter
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: clutter-maint
clutter-maint
Depends on:
Blocks:
 
 
Reported: 2013-01-24 20:02 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2013-01-28 17:46 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
x11: Always request XI2.2 (1.11 KB, patch)
2013-01-24 20:02 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review
clutter-backend: Request XI2.3 (1.09 KB, patch)
2013-01-24 20:02 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review

Description Jasper St. Pierre (not reading bugmail) 2013-01-24 20:02:29 UTC 
As XIQueryVersion is broken, we need to bump, yet again.
Comment 1 Jasper St. Pierre (not reading bugmail) 2013-01-24 20:02:31 UTC 
Created attachment 234321 [details] [review]
x11: Always request XI2.2

The X server should fill in the minor version that it supports in the
case where it only supports the older version. We should not get a
BadRequest or fail the version check if we pass something higher.
Comment 2 Jasper St. Pierre (not reading bugmail) 2013-01-24 20:02:33 UTC 
Created attachment 234322 [details] [review]
clutter-backend: Request XI2.3

Since XIQueryVersion, the bad API that it is, chooses the first client
version that it gets, we need to ensure that we pass XIQueryVersion the
new XI2.3 version, knowing fully well that Clutter won't be confused
by the new features.
Comment 3 Emmanuele Bassi (:ebassi) 2013-01-25 08:00:29 UTC 
Review of attachment 234321 [details] [review]:

looks okay.
Comment 4 Emmanuele Bassi (:ebassi) 2013-01-25 08:00:55 UTC 
Review of attachment 234322 [details] [review]:

looks okay.
Comment 5 Jasper St. Pierre (not reading bugmail) 2013-01-28 17:46:26 UTC 
Attachment 234321 [details] pushed as b58a1d6 - x11: Always request XI2.2
Attachment 234322 [details] pushed as 3e1450b - clutter-backend: Request XI2.3