Created attachment 234289 [details] [review]
Proposed patch to fix <Alt>Above_Tab not cycling through windows

When the "switch_group" keyboard binding is set to <Alt>Above_Tab (the default), you cannot cycle through any of the application's windows.  Namely, when you

Press <Alt>
Press, release Backtick
Press, release Backtick
. . .
Release <Alt>

The first press/release of Backtick will bring up the group cycle dialog as expected, but the second press/release of Backtick does not cycle to the next window.  Rather, it dismisses the dialog.

Setting the "switch_group" keyboard binding to <Alt>Backtick works around this issue.

The problem appears to be in display_get_keybinding_action(), where the pressed keysym is compared to all of the registered keybindings.  However, the stored keysym for the "switch_group" keybinding is the special keysym META_KEY_ABOVE_TAB, and so the pressed keysym never matches it.

The proposed patch I've attached fixes the issue by ignoring the pressed keysym when a registered keybinding's keysym is META_KEY_ABOVE_TAB, in which case only compare the pressed keycode and mask to that of that keybinding.