After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 692398 - Use the G_DEFINE_QUARK macro
Use the G_DEFINE_QUARK macro
Status: RESOLVED FIXED
Product: evolution-data-server
Classification: Platform
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Evolution Shell Maintainers Team
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2013-01-23 16:15 UTC by Mathias Hasselmann (IRC: tbf)
Modified: 2013-01-24 12:26 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed patch (10.40 KB, patch)
2013-01-23 16:16 UTC, Mathias Hasselmann (IRC: tbf) 		committed Details | Review

Description Mathias Hasselmann (IRC: tbf) 2013-01-23 16:15:15 UTC 
This macro got introduced with glib 2.34, which is required by EDS master.

Using this macro reduces boilerplate and ensures that quark definition functions make proper use of the G_UNLIKELY macro.
Comment 1 Mathias Hasselmann (IRC: tbf) 2013-01-23 16:16:15 UTC 
Created attachment 234222 [details] [review]
proposed patch
Comment 2 Matthew Barnes 2013-01-23 16:22:29 UTC 
Nice cleanup.  Go ahead.
Comment 3 Mathias Hasselmann (IRC: tbf) 2013-01-24 08:38:57 UTC 
Thank you for looking. Patch has landed.
Comment 4 Milan Crha 2013-01-24 12:26:44 UTC 
Except of one thing, the configure.ac change is wrong, please revert that part.