After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 692372 - xrandr: Don't operate on a NULL object
xrandr: Don't operate on a NULL object
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: xrandr
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-settings-daemon-maint
gnome-settings-daemon-maint
Depends on:
Blocks:
 
 
Reported: 2013-01-23 10:54 UTC by Matthias Clasen
Modified: 2013-01-23 16:41 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
xrandr: Don't operate on a NULL object (2.66 KB, patch)
2013-01-23 10:54 UTC, Matthias Clasen
committed Details | Review

Description Matthias Clasen 2013-01-23 10:54:18 UTC
I see a critical out of gnome_rr_config_set_clone in my session log.
It turns out all uses of that function in the xrandr plugin are
happening after possibly nulling the GnomeRRConfig they are operating
on. Correct that.
Comment 1 Matthias Clasen 2013-01-23 10:54:21 UTC
Created attachment 234175 [details] [review]
xrandr: Don't operate on a NULL object
Comment 2 Bastien Nocera 2013-01-23 11:47:14 UTC
This comes from:

commit 5f7643800a8bc26bd2835dc9a3df085bf0fab422
Author: Ray Strode <rstrode@redhat.com>
Date:   Tue Jun 5 10:30:06 2012 -0400

    xrandr: explicitly set clone state variable when generating monitor configs
    
    Each potential monitor configuration that can be cycled through with
    fn-f7 on laptops is generated by copying and tweaking the current
    monitor configuration.
    
    One necessary, but neglected tweak, was the current "clone" state.  This
    means the clone state of the current configuration leaks into every
    other config. Users who start in a cloned mode can never leave a clone
    with the hotkey.
    
    This commit explicitly sets the clone state appropriately.
    
    Patch based on valuable, and detailed feedback provided by Marico Xu.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=677472


Ray?
Comment 3 Bastien Nocera 2013-01-23 12:08:10 UTC
It would need to go in to gnome-3-6 as well I think.
Comment 4 Ray Strode [halfline] 2013-01-23 16:41:49 UTC
Attachment 234175 [details] pushed as 92b5f78 - xrandr: Don't operate on a NULL object

Thanks, that's embarassing!  It looks like it was a pretty benign bug, fortunately.
The important part: that clone state gets set properly when the returning a valid
object was okay.