After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 692336 - Improve Oops! screens
Improve Oops! screens
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Interface
3.6.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-01-22 22:49 UTC by Faizal Luthfi
Modified: 2013-12-17 15:53 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Epiphany error message not centered (62.48 KB, image/png)
2013-01-22 22:49 UTC, Faizal Luthfi 		  Details
Improve oops screens (11.46 KB, patch)
2013-12-15 20:58 UTC, William Jon McCann 		committed Details | Review

Description Faizal Luthfi 2013-01-22 22:49:41 UTC 
Created attachment 234150 [details]
Epiphany error message not centered

Epiphany error message not centered. This happen in my small screen netbook, 10inch.
Comment 1 William Jon McCann 2013-12-15 20:58:31 UTC 
Created attachment 264245 [details] [review]
Improve oops screens
Comment 2 Gustavo Noronha (kov) 2013-12-17 15:23:21 UTC 
Review of attachment 264245 [details] [review]:

I like it. If we use GResource we could also drop the function that opens the CSS file ;) it'll be great.

::: embed/ephy-web-view.c
@@ +1700,3 @@
+  file = ephy_file ("error.css");
+  if (file && !g_file_get_contents (file, &sheet, NULL, &error)) {
+    g_debug ("%s", error->message);

Maybe add something that would help identify this code path before the error message?
Comment 3 William Jon McCann 2013-12-17 15:53:48 UTC 
Attachment 264245 [details] pushed as c36eec7 - Improve oops screens