GNOME Bugzilla – Bug 692276
Don't assume that secret_password_clear_sync() returns FALSE on error
Last modified: 2013-01-22 13:11:53 UTC
When I delete an Online Account for which no password exists in the keyring I get an erroneous error message saying that it failed to delete items from the keyring. This is due to the incorrect use of secret_password_clear_sync().
Created attachment 234092 [details] [review] Don't assume that secret_password_clear_sync() returns FALSE on error The secret_password_clear_sync() function returns whether items were deleted or not, and returning FALSE does not indicate an error condition. Detect the error condition correctly, preventing erroneus error prompts about not being able to delete stuff from the keyring.
Created attachment 234100 [details] [review] Don't assume that secret_password_clear_sync() returns FALSE on error The secret_password_clear_sync() function returns whether items were deleted or not, and returning FALSE does not indicate an error condition. Detect the error condition correctly, preventing erroneus error prompts about not being able to delete stuff from the keyring.
Created attachment 234101 [details] [review] Don't assume that secret_password_clear_sync() returns FALSE on error The secret_password_clear_sync() function returns whether items were deleted or not, and returning FALSE does not indicate an error condition. Detect the error condition correctly, preventing erroneus error prompts about not being able to delete stuff from the keyring.
Comment on attachment 234101 [details] [review] Don't assume that secret_password_clear_sync() returns FALSE on error Thanks for the patch. Committed and pushed as fe57f4830d114638310589f47b36269bf504246b after a very minor style fix.