After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 692265 - codecparsers: h264: add inferred value for slice_beta_offset_div2
codecparsers: h264: add inferred value for slice_beta_offset_div2
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 1.0.6
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-01-22 10:02 UTC by Gwenole Beauchesne
Modified: 2013-06-12 09:49 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
codecparsers: h264: add inferred value for slice_beta_offset_div2 (1.17 KB, patch)
2013-01-22 10:02 UTC, Gwenole Beauchesne
committed Details | Review

Description Gwenole Beauchesne 2013-01-22 10:02:30 UTC
Created attachment 234083 [details] [review]
codecparsers: h264: add inferred value for  slice_beta_offset_div2

Hi, the standard specifies that when slice_beta_offset_div2 is not present in the slice header, then the value of slice_beta_offset_div2 shall be inferred to be equal to 0.

BTW, slice_alpha_c0_offset_div2 already had the same treatment.

I plan to apply this patch to all GStreamer branches: 0.10, 1.0 and master.
Comment 1 Tim-Philipp Müller 2013-01-24 23:25:33 UTC
commit 56e2405a3575a2326b496afc9901492c34450175
Author: Gwenole Beauchesne <gwenole.beauchesne@intel.com>
Date:   Sun Jan 6 18:54:52 2013 +0100

    codecparsers: h264: add inferred value for slice_beta_offset_div2.
    
    The standard specifies that when slice_beta_offset_div2 is not present
    in the slice header, then the value of slice_beta_offset_div2 shall be
    inferred to be equal to 0.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=692265
    
    Signed-off-by: Gwenole Beauchesne <gwenole.beauchesne@intel.com>
Comment 2 RajuB 2013-06-12 08:48:38 UTC
Hi,

I am using gstreamer-1.0.4 version, which doesnt has this fix. What is the impact of this bug on the other elements like demuxers,decoders,encoders,muxerx??

regards
JasonP
Comment 3 Gwenole Beauchesne 2013-06-12 09:40:06 UTC
Hi,

(In reply to comment #2)
> I am using gstreamer-1.0.4 version, which doesnt has this fix. What is the
> impact of this bug on the other elements like
> demuxers,decoders,encoders,muxerx??

This bug only affected newer versions of gstreamer-vaapi, where we actually use that field. For other elements, there should not be any impact as this field was either not used, or the data structures were initially memset() to zero.
Comment 4 RajuB 2013-06-12 09:49:29 UTC
great. Thanks for you quick reply Gwenole.

regards
JasonP