GNOME Bugzilla – Bug 692234
Segmentation fault dropping on sidebar after switching location on hover
Last modified: 2013-01-22 15:51:48 UTC
Created attachment 234046 [details] backtrace Steps to reproduce: Drag file. Hover a sidebar row while dragging. Wait until location switches. Drop file on that row. Results: I get this on terminal: (nautilus:9480): Gtk-CRITICAL **: gtk_tree_model_get_iter: assertion `path != NULL' failed Segmentation fault (core dumped) If the row is "Trash", nautilus doesn't crash, nautilus doesn't crash, but it still leaves a the "Gtk-CRITICAL" message on terminal. Maybe related: Bug 692230
Created attachment 234076 [details] [review] Cache drag selections on drag begin Since the contents of the view may change.
Created attachment 234077 [details] [review] Keep a ref to the drop files So they will still be around when the parent model goes away.
Created attachment 234078 [details] [review] Remove cut and paste libegg
Created attachment 234079 [details] [review] Normalize signal names
Review of attachment 234076 [details] [review]: Thanks, looks good to me. Minior nitpick below ::: src/nautilus-list-view.c @@ +442,3 @@ + } + + GtkTreeView *treeview; Shouldn't this use the drag view treeview as well?
Review of attachment 234077 [details] [review]: ++
Review of attachment 234078 [details] [review]: Yes!
Review of attachment 234079 [details] [review]: Thanks!
Attachment 234076 [details] pushed as 1b4eec6 - Cache drag selections on drag begin Attachment 234077 [details] pushed as 3c22e4c - Keep a ref to the drop files Attachment 234078 [details] pushed as 898573b - Remove cut and paste libegg Attachment 234079 [details] pushed as d721a8f - Normalize signal names
*** Bug 692230 has been marked as a duplicate of this bug. ***