GNOME Bugzilla – Bug 692231
Footers don't go all the way down if screen is too high
Last modified: 2018-09-24 10:29:02 UTC
Need to find a strategy to make it go all the way to the bottom.
As for now, it depends on the amount of content in the page. There seems to be some ways to fix this, but it needs to play well together with the 960 framework. A google search for "sticky footer" reveals some alternatives.
Created attachment 259062 [details] Attachment contains the full code. This attachment contains the theme with the bug fixed.
Created attachment 259124 [details] [review] This is the patch for above edited code.
Created attachment 259136 [details] [review] Solved the bug footers don't go all the way down when screen too high
Monam: Can you make sure it's possible to apply the patch from the top level directory? Right now it looks like it needs to be applied inside the theme directory, instead of the top level directory.
Sorry, nevermind, ignore the above comment, I mixed it up with something else.
@Monam: seems the patch isn't working as expected, the footer is still not being sticky and the homepage was broken. How did you test the patch? do you have a local mailman installation to test this?
I tested the attachment which i posted earlier on various browsers like firefox, Chrome and IE8. It worked fine on all these platforms. However i have no mechanism to test the patch
*** Bug 700482 has been marked as a duplicate of this bug. ***
Created attachment 295169 [details] [review] Sticky footer bug 692231 A javascript method of ensuring that the footer (and its artwork) always sits at the bottom of the screen
Another solution using CSS flex (also used on gnome.org). Compatibility: Modern browsers have flex support, see also http://caniuse.com/#search=flex CSS code: /* Sticky Footer */ .gnome-body { display: flex; flex-direction: column; min-height: 100vh; } .gnome-content{ flex: 1; } HTML markup: <html> <body class="gnome-body "> <div class="gnome-content"> Page content </div> <!-- Fotoer remains to the bottom --> <footer> Content </footer> </body> </html>
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/Infrastructure/Websites/issues/105.