GNOME Bugzilla – Bug 692219
gnome-xkb-info: Handle duplicated layouts
Last modified: 2013-02-27 18:25:38 UTC
This should fix some weird errors and crashes that I've seen being reported.
Created attachment 234031 [details] [review] gnome-xkb-info: Handle duplicated layouts When merging entries from another .xml file (i.e. when show-all-sources is active) there might be layout entries which were already added before. In that case we don't want to create new entries and replace the old ones because layout variants which were already added depend on the existence of the old main layout.
Still crashes for me with that patch, unfortunately. As a hint, it crashes in the second sort_sequences call, ie only if show-all-sources is true
Created attachment 234604 [details] [review] gnome-xkb-info: Handle duplicated layouts When merging entries from another .xml file (i.e. when show-all-sources is active) there might be layout entries which were already added before. In that case we don't want to create new entries and replace the old ones because layout variants which were already added depend on the existence of the old main layout. We must also keep the languages and countries sequences sorted while inserting so that we can check if a layout is already there and skip adding it then. -- This should fix it.
Comment on attachment 234604 [details] [review] gnome-xkb-info: Handle duplicated layouts I've decided to stop using GSequence here so disregard this patch.
Comment on attachment 234031 [details] [review] gnome-xkb-info: Handle duplicated layouts We should use this instead for the issue at hand here.
*** Bug 692751 has been marked as a duplicate of this bug. ***
Created attachment 236011 [details] [review] gnome-xkb-info: Handle duplicated layouts -- rebased
Attachment 236011 [details] pushed as b3e4aef - gnome-xkb-info: Handle duplicated layouts
*** Bug 694149 has been marked as a duplicate of this bug. ***
*** Bug 693990 has been marked as a duplicate of this bug. ***