After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 692163 - file chooser: give GSettings schema a path
file chooser: give GSettings schema a path
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2013-01-21 02:28 UTC by Allison Karlitskaya (desrt)
Modified: 2013-01-23 12:48 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
file chooser: give GSettings schema a path (1.67 KB, patch)
2013-01-21 02:28 UTC, Allison Karlitskaya (desrt)
accepted-commit_now Details | Review

Description Allison Karlitskaya (desrt) 2013-01-21 02:28:27 UTC
See patch.
Comment 1 Allison Karlitskaya (desrt) 2013-01-21 02:28:29 UTC
Created attachment 233978 [details] [review]
file chooser: give GSettings schema a path

The code is always instantiating this schema at a fixed location, so why
is it relocatable?

Add a path so that it shows up properly in dconf-editor, and from the
gsettings commandline tool.
Comment 2 Matthias Clasen 2013-01-21 04:22:54 UTC
Review of attachment 233978 [details] [review]:

Yep
Comment 3 Matthias Clasen 2013-01-21 04:25:01 UTC
Can you also fix the colorchooser schema while you're at it ?
Comment 4 Benjamin Otte (Company) 2013-01-22 17:07:19 UTC
Is it a good idea to have multiple schemas?

Could we have just one global GSettings object and use that everywhere?
Comment 5 Matthias Clasen 2013-01-23 12:48:36 UTC
Lets go with this for now.