After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 692148 - custom command set in profile is not executed when opening terminal
custom command set in profile is not executed when opening terminal
Status: RESOLVED FIXED
Product: gnome-terminal
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME Terminal Maintainers
GNOME Terminal Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-01-20 20:55 UTC by Frederic Peters
Modified: 2013-01-20 21:22 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
terminal-screen: check for custom command first (1.93 KB, patch)
2013-01-20 20:55 UTC, Frederic Peters 		none Details | Review

Description Frederic Peters 2013-01-20 20:55:51 UTC 
terminal_screen_new() calls terminal_screen_set_override_command() with
its third parameter, shell, set to FALSE if there is no override_command,
but that means get_child_command() will enter its "if (priv->shell)" code
path, and not check for TERMINAL_PROFILE_USE_CUSTOM_COMMAND_KEY,
therefore not running the custom command that may have been set.

This simple patch moves the "if (priv->shell)" check after other checks.
Comment 1 Frederic Peters 2013-01-20 20:55:54 UTC 
Created attachment 233962 [details] [review]
terminal-screen: check for custom command first
Comment 2 Christian Persch 2013-01-20 21:01:07 UTC 
Looks good, please commit. Thanks!
Comment 3 Frederic Peters 2013-01-20 21:22:40 UTC 
commit 7997f486ff3df49ce1b87413c9ba07be72ee8b28
Author: Frédéric Péters <fpeters@0d.be>
Date:   Sun Jan 20 21:50:55 2013 +0100

    terminal-screen: check for custom command first
    
    https://bugzilla.gnome.org/show_bug.cgi?id=692148