After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 692139 - continue button lacks padding
continue button lacks padding
Status: RESOLVED FIXED
Product: gnome-boxes
Classification: Applications
Component: wizard
3.6.x
Other Linux
: Normal normal
: --
Assigned To: GNOME Boxes maintainer(s)
GNOME Boxes maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-01-20 15:06 UTC by Andreas Nilsson
Modified: 2016-03-31 14:01 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
screenshot (21.88 KB, image/png)
2013-01-20 15:06 UTC, Andreas Nilsson 		  Details
Update to latest libgd (528 bytes, patch)
2013-01-22 23:02 UTC, Cosimo Cecchi 		committed Details | Review

Description Andreas Nilsson 2013-01-20 15:06:26 UTC 
Created attachment 233950 [details]
screenshot

The text on the button is all crammed towards the sides of the button.
Comment 1 Andreas Nilsson 2013-01-20 15:08:35 UTC 
Mockup by jimmac for comparison.
https://raw.github.com/gnome-design-team/gnome-mockups/master/boxes/boxes-install2.1.png
Comment 2 Andreas Nilsson 2013-01-20 15:10:00 UTC 
the Cancel button also suffers some a bit of the same issue, but not as severe as Continue
Comment 3 Alexander Larsson 2013-01-21 08:33:54 UTC 
The padding on the cancel/back buttons is just due to the buttons being made the same size. We should just add some l/r padding to all buttons.
Comment 4 Alexander Larsson 2013-01-22 11:33:22 UTC 
This is due to adwaita doing:

.toolbar .button {
    padding: 1px;
}

Setting the left/right padding to 0.

This was done in:
http://git.gnome.org/browse/gnome-themes-standard/commit/?id=bb123011881e2adeba9504a2e5a15ad3464281e6

not sure exactly why, but its been some time since then and e.g. -GtkButton-inner-border which Adwaita still uses has become ignored since then. So maybe its an accidental issue?
Comment 5 Cosimo Cecchi 2013-01-22 23:02:04 UTC 
Created attachment 234154 [details] [review]
Update to latest libgd

--

I now fixed the style used for those toolbar buttons in GdMainToolbar/Adwaita. The latest version of GdMainToolbar is needed to get the right padding; attached patch bumps the libgd version.
Comment 6 Alexander Larsson 2013-01-23 08:34:37 UTC 
Review of attachment 234154 [details] [review]:

ack
Comment 7 Alexander Larsson 2013-01-23 08:38:58 UTC 
Attachment 234154 [details] pushed as ccf7918 - Update to latest libgd