After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 692130 - check for -Werror=format-security broken
check for -Werror=format-security broken
Status: RESOLVED OBSOLETE
Product: glib
Classification: Platform
Component: build
unspecified
Other Linux
: Normal major
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2013-01-20 12:41 UTC by Christian Persch
Modified: 2018-05-24 14:57 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Christian Persch 2013-01-20 12:41:08 UTC
configure tries to check a list of warning flags to use. The check for the -Werror=format-security check however will return false since it checks the flags one-by-one, and format-security only works if used together with -Wformat:

configure:28656: checking if gcc supports flag -Werror=format-security in envvar CFLAGS
configure:28667: gcc -c -Werror -Werror=format-security  -pthread conftest.c >&5
cc1: error: -Wformat-security ignored without -Wformat [-Werror=format-security]
cc1: all warnings being treated as errors
configure:28667: $? = 1

This results in the build never actually using -Werror=format-security (nor -Wformat-security), so these errors will go unchecked.

glib git master, gcc (GCC) 4.7.2 20120921 (Red Hat 4.7.2-2).
Comment 1 Matthias Clasen 2013-01-20 19:54:10 UTC
I'd argue that the compiler is broken here...
Comment 2 GNOME Infrastructure Team 2018-05-24 14:57:02 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/glib/issues/656.