GNOME Bugzilla – Bug 692097
Allow drag and drop to any folder
Last modified: 2013-01-22 20:45:15 UTC
Currently we allow the user to switch tabs when dragging a file but we should really allow the user to drop into any location directly from a drag.
Created attachment 233892 [details] [review] Switch views when hovering over pathbar
Created attachment 233893 [details] [review] Switch location on places sidebar hover
Created attachment 233894 [details] [review] Switch location on list view hover
Created attachment 233895 [details] [review] Switch location on canvas view hover
Review of attachment 233892 [details] [review]: Looks good
Review of attachment 233893 [details] [review]: Looks good, with some minor comments. ::: src/nautilus-places-sidebar.c @@ +1163,3 @@ + sidebar->switch_location_timer = 0; + +switch_location_timer (gpointer user_data) You can use sidebar->window directly here. @@ +1183,3 @@ + + if (sidebar->switch_location_timer != 0) { + g_assert (NAUTILUS_IS_WINDOW (window)); remove_switch_location_timer() already checks if the timer is != 0
Review of attachment 233894 [details] [review]: Looks good
Review of attachment 233895 [details] [review]: Looks good, except for a minor comment ::: libnautilus-private/nautilus-canvas-dnd.c @@ +1495,3 @@ + dnd_info = container->details->dnd_info; + + return FALSE; This != check is already performed by remove_hover_timer()
Attachment 233892 [details] pushed as 87bb40d - Switch views when hovering over pathbar Attachment 233893 [details] pushed as 9540054 - Switch location on places sidebar hover Attachment 233894 [details] pushed as 0d635bd - Switch location on list view hover Attachment 233895 [details] pushed as 161b842 - Switch location on canvas view hover
Very handy feature, great! Would it be possible to enhance this feature for folders, too. So, if the user hovers a folder on the right file list this folder opens, too?
That's what it does.