After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 692097 - Allow drag and drop to any folder
Allow drag and drop to any folder
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-01-19 19:57 UTC by William Jon McCann
Modified: 2013-01-22 20:45 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Switch views when hovering over pathbar (4.59 KB, patch)
2013-01-19 19:58 UTC, William Jon McCann
committed Details | Review
Switch location on places sidebar hover (3.91 KB, patch)
2013-01-19 19:58 UTC, William Jon McCann
committed Details | Review
Switch location on list view hover (6.25 KB, patch)
2013-01-19 19:58 UTC, William Jon McCann
committed Details | Review
Switch location on canvas view hover (6.37 KB, patch)
2013-01-19 19:59 UTC, William Jon McCann
committed Details | Review

Description William Jon McCann 2013-01-19 19:57:29 UTC
Currently we allow the user to switch tabs when dragging a file but we should really allow the user to drop into any location directly from a drag.
Comment 1 William Jon McCann 2013-01-19 19:58:54 UTC
Created attachment 233892 [details] [review]
Switch views when hovering over pathbar
Comment 2 William Jon McCann 2013-01-19 19:58:56 UTC
Created attachment 233893 [details] [review]
Switch location on places sidebar hover
Comment 3 William Jon McCann 2013-01-19 19:58:58 UTC
Created attachment 233894 [details] [review]
Switch location on list view hover
Comment 4 William Jon McCann 2013-01-19 19:59:01 UTC
Created attachment 233895 [details] [review]
Switch location on canvas view hover
Comment 5 Cosimo Cecchi 2013-01-21 15:15:08 UTC
Review of attachment 233892 [details] [review]:

Looks good
Comment 6 Cosimo Cecchi 2013-01-21 15:19:11 UTC
Review of attachment 233893 [details] [review]:

Looks good, with some minor comments.

::: src/nautilus-places-sidebar.c
@@ +1163,3 @@
+	sidebar->switch_location_timer = 0;
+
+switch_location_timer (gpointer user_data)

You can use sidebar->window directly here.

@@ +1183,3 @@
+
+	if (sidebar->switch_location_timer != 0) {
+	g_assert (NAUTILUS_IS_WINDOW (window));

remove_switch_location_timer() already checks if the timer is != 0
Comment 7 Cosimo Cecchi 2013-01-21 15:22:37 UTC
Review of attachment 233894 [details] [review]:

Looks good
Comment 8 Cosimo Cecchi 2013-01-21 15:24:04 UTC
Review of attachment 233895 [details] [review]:

Looks good, except for a minor comment

::: libnautilus-private/nautilus-canvas-dnd.c
@@ +1495,3 @@
+	dnd_info = container->details->dnd_info;
+
+	return FALSE;

This != check is already performed by remove_hover_timer()
Comment 9 William Jon McCann 2013-01-21 16:09:09 UTC
Attachment 233892 [details] pushed as 87bb40d - Switch views when hovering over pathbar
Attachment 233893 [details] pushed as 9540054 - Switch location on places sidebar hover
Attachment 233894 [details] pushed as 0d635bd - Switch location on list view hover
Attachment 233895 [details] pushed as 161b842 - Switch location on canvas view hover
Comment 10 t.ask 2013-01-22 20:40:19 UTC
Very handy feature, great!

Would it be possible to enhance this feature for folders, too. So, if the user hovers a folder on the right file list this folder opens, too?
Comment 11 William Jon McCann 2013-01-22 20:45:15 UTC
That's what it does.