After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 692073 - $(EXEEXT) is missing for gtk-update-icon-cache
$(EXEEXT) is missing for gtk-update-icon-cache
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Backend: Win32
3.7.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-win32 maintainers
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2013-01-19 13:13 UTC by Kouhei Sutou
Modified: 2013-01-21 03:23 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add missing $(EXEEXT) (662 bytes, patch)
2013-01-19 13:13 UTC, Kouhei Sutou 		committed Details | Review

Description Kouhei Sutou 2013-01-19 13:13:33 UTC 
Created attachment 233861 [details] [review]
Add missing $(EXEEXT)

$(EXEEXT) is missing for gtk-update-icon-cache in gtk/Makefile.am.
$(EXEEXT) isn't missing in gtkbuiltincache.h:

gtk/Makefile.am:
...
1669  	$(AM_V_at) $(MAKE) $(AM_MAKEFLAGS) gtk-update-icon-cache$(EXEEXT)
...

But $(EXEEXT) is missing in gtk_update_icon_cache_program:

gtk/Makefile.am:
...
1660  gtk_update_icon_cache_program = ./gtk-update-icon-cache
...

$(EXEEXT) isn't required for building GTK+ on Windows. But it is required
for building GTK+ for Windows with Wine on GNU/Linux. Because GNU/Linux
doesn't complement .exe automatically.
Comment 1 Matthias Clasen 2013-01-20 22:48:54 UTC 
Review of attachment 233861 [details] [review]:

ok
Comment 2 Matthias Clasen 2013-01-21 03:23:08 UTC 
Attachment 233861 [details] pushed as ce15472 - Add missing $(EXEEXT)