After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 692065 - vino-server SIGABRT, "buffer overflow detected" in clipboard handling code
vino-server SIGABRT, "buffer overflow detected" in clipboard handling code
Status: RESOLVED WONTFIX
Product: vino
Classification: Applications
Component: Server
3.6.x
Other Linux
: Normal critical
: ---
Assigned To: Vino Maintainer(s)
Vino Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-01-19 11:59 UTC by melchiaros
Modified: 2020-11-12 12:24 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
check sock fd before deref (432 bytes, patch)
2013-01-19 16:10 UTC, David King
none Details | Review

Description melchiaros 2013-01-19 11:59:01 UTC
This is an upstream report of vino crash, which occures the first time with package vino 3.3.92 in Ubuntu12.04 and is still actual up to package vino 3.6.2 in Ubuntu13.04 development branch. During time launchpad has counted 24 who are affected by stacktrace identification.

The original report can be found at:

https://bugs.launchpad.net/ubuntu/+source/vino/+bug/960649

and list all dublicates over different versions.

A stactrace is available only for the 3.3.92 version and will be attached here.

Unfortunally I am by myself not able to hit the crash on any version, so a stacktrace from myself is not available(I only bring this upstream). Anyway, the stacktrace top is listed as still the same for any affected version.

Also no one of the affected people is able to give a valid reproducing procedure as can be seen by the comments in the dublicates(crash randomly).


The header of 

https://bugs.launchpad.net/ubuntu/+source/vino/+bug/960649

will be copied here and the available stacktrace will be attached.

If there is need to test any further please contact the 24 affected people automatically by simple commenting on the launchpad report.

Thanks

---------------------------------------------(header of launchpad bug):

vino crashed in the background while I was doing unrelated tasks in the foreground.

ProblemType: Crash
DistroRelease: Ubuntu 12.04
Package: vino 3.3.92-0ubuntu1
ProcVersionSignature: Ubuntu 3.2.0-19.30-generic 3.2.11
Uname: Linux 3.2.0-19-generic x86_64
NonfreeKernelModules: nvidia
ApportVersion: 1.94.1-0ubuntu2
Architecture: amd64
Date: Tue Mar 20 23:49:49 2012
ExecutablePath: /usr/lib/vino/vino-server
InstallationMedia: Ubuntu 12.04 LTS "Precise Pangolin" - Alpha amd64 (20120315)
ProcCmdline: /usr/lib/vino/vino-server --sm-disable
Signal: 6
SourcePackage: vino
StacktraceTop:
 raise () from /lib/x86_64-linux-gnu/libc.so.6
 abort () from /lib/x86_64-linux-gnu/libc.so.6
 ?? () from /lib/x86_64-linux-gnu/libc.so.6
 __fortify_fail () from /lib/x86_64-linux-gnu/libc.so.6
 __chk_fail () from /lib/x86_64-linux-gnu/libc.so.6
Title: vino-server crashed with SIGABRT in raise()
UpgradeStatus: No upgrade log present (probably fresh install)
UserGroups: adm cdrom dip lpadmin plugdev sambashare sudo
Comment 1 melchiaros 2013-01-19 11:59:31 UTC


  • #0 __GI_raise
    at ../nptl/sysdeps/unix/sysv/linux/raise.c line 64
  • #1 __GI_abort
    at abort.c line 91
  • #2 __libc_message
    at ../sysdeps/unix/sysv/linux/libc_fatal.c line 201
  • #3 __GI___fortify_fail
    at fortify_fail.c line 32
  • #4 __GI___chk_fail
    at chk_fail.c line 29
  • #5 __fdelt_chk
    at fdelt_chk.c line 26
  • #6 rfbCloseClient
    at server/libvncserver/sockets.c line 353
  • #7 rfbSendServerCutText
    at server/libvncserver/rfbserver.c line 1544
  • #8 vino_server_clipboard_cb
    at server/vino-server.c line 952
  • #9 vino_server_clipboard_cb
    at server/vino-server.c line 929
  • #10 g_closure_invoke
    at /build/buildd/glib2.0-2.31.22/./gobject/gclosure.c line 777
  • #11 signal_emit_unlocked_R
    at /build/buildd/glib2.0-2.31.22/./gobject/gsignal.c line 3547
  • #12 g_signal_emit_valist
    at /build/buildd/glib2.0-2.31.22/./gobject/gsignal.c line 3296
  • #13 g_signal_emit
    at /build/buildd/glib2.0-2.31.22/./gobject/gsignal.c line 3352
  • #14 check_setugid
    at /build/buildd/gtk+3.0-3.3.20/./gtk/gtkmain.c line 362
  • #15 ??
  • #16 ??
  • #17 ??
  • #18 ??

Comment 2 David King 2013-01-19 16:10:20 UTC
Created attachment 233871 [details] [review]
check sock fd before deref

Thanks for the bug report. I had a look at the code in the stack trace and there seems to be some leftovers from when threading support was removed from the libvncserver included in Vino. Can you try the attached patch and see if it fixes the problem for those affected?
Comment 3 melchiaros 2013-01-19 16:23:37 UTC
Hi David,

wow that was fast.

I can download the patch here and attach it don the launchpad ticket.

Launchpad will identify it and mark the ticket with the tag patch. After this a review will be there(from the crash bug triager team when I know correctly).

After this it could be incorporated and a new package will be build for the proposed repositories.

Than the launchpad ticket will be marked with verification-needed and those who want to test can do.

In the case of successfull working one of the users add the tag verification-done and the patched packages will migrate into the main repositories.
.
.
.
This is the long story:)


Anyway, when the patch is on launchpad attached anyone who fell so can apply the patch by him/herself and look if it helps.  May be you can subscribe to the launchpad ticket and ask the people for doing this. This might be easier as to subscibe all of them here.(I know GNOME is not on launchpad, but for easyness...)

There might also be communication need from one of the Ubuntu developers(I am only doing on bug triaging).
Comment 4 melchiaros 2013-01-19 16:41:00 UTC
The patch is attached at the launchpad ticket, and I have wrote a short text that ask for testing. The rest is waiting.
Comment 5 André Klapper 2020-11-12 12:24:29 UTC
Vino is not under active development anymore and unmaintained.

Please use gnome-remote-desktop instead.

Closing this report as WONTFIX to reflect reality.