GNOME Bugzilla – Bug 692055
Update .gitignore and autoconf
Last modified: 2013-01-20 17:05:00 UTC
See patches. I couldn't get rid of omf.make and xmldocs.make, I assume those are pulled in by gconf or something else.
Created attachment 233841 [details] [review] src: Make sure to include git.mk
Created attachment 233842 [details] [review] Update copy of git.mk
Created attachment 233843 [details] [review] configure.ac: Use AM_PATH_GLIB_2_0 instead of custom PATH_PROG goo
Created attachment 233844 [details] [review] configure.ac: Replace custom warnings goo with GNOME_COMPILE_WARNINGS
I committed the first two patches. I'm not going to use AM_PATH_GLIB_2_0 since IMHO that macro should disappear instead of being used *more* widely. And since we use a longer list of compile warnings anyway, I just updated the list instead of using more gnome-common macros (since also IMHO those macros should disappear).
(In reply to comment #5) > I committed the first two patches. I'm not going to use AM_PATH_GLIB_2_0 since > IMHO that macro should disappear instead of being used *more* widely. And since > we use a longer list of compile warnings anyway, I just updated the list > instead of using more gnome-common macros (since also IMHO those macros should > disappear). I'm curious why. AM_PATH_GLIB_2_0 is one line that does most everything that the current script does, and GNOME_COMPILE_WARNINGS just got a large update to the set of compiler warnings it has.
I can't even count the time lost over the years to the stupid 'pkg-config said version x, but it's really version y' check in that macro. Unless I'm missing something, GNOME_COMPILE_WARNINGS just has a very minimal set of flags, much less than the list g-t uses currently ?