After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 692052 - Modernize our autoconfs
Modernize our autoconfs
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-01-19 04:29 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2013-01-19 18:39 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
configure.ac: Use GNOME_COMPILE_WARNINGS (1.70 KB, patch)
2013-01-19 04:29 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review
configure.ac: Remove checks for JS_NewGlobalObject (762 bytes, patch)
2013-01-19 04:29 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review
configure.ac: Remove an old variable (889 bytes, patch)
2013-01-19 04:29 UTC, Jasper St. Pierre (not reading bugmail) 		rejected Details | Review
configure.ac: Remove old introspection infrastructure (1.12 KB, patch)
2013-01-19 04:30 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review
configure.ac: Rearrange pkg-config checks (2.16 KB, patch)
2013-01-19 04:30 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review
configure.ac: Remove deprecated macro (802 bytes, patch)
2013-01-19 04:33 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review

Description Jasper St. Pierre (not reading bugmail) 2013-01-19 04:29:50 UTC 
Just clean up some cruft that's accumulated over the years.
Comment 1 Jasper St. Pierre (not reading bugmail) 2013-01-19 04:29:53 UTC 
Created attachment 233827 [details] [review]
configure.ac: Use GNOME_COMPILE_WARNINGS

This is now implemented as standard in gnome-common.
Comment 2 Jasper St. Pierre (not reading bugmail) 2013-01-19 04:29:55 UTC 
Created attachment 233828 [details] [review]
configure.ac: Remove checks for JS_NewGlobalObject

The need for this is long gone.
Comment 3 Jasper St. Pierre (not reading bugmail) 2013-01-19 04:29:58 UTC 
Created attachment 233829 [details] [review]
configure.ac: Remove an old variable

I don't think anything has ever needed this in a long time.
Comment 4 Jasper St. Pierre (not reading bugmail) 2013-01-19 04:30:01 UTC 
Created attachment 233830 [details] [review]
configure.ac: Remove old introspection infrastructure

This hasn't been needed in quite some time.
Comment 5 Jasper St. Pierre (not reading bugmail) 2013-01-19 04:30:04 UTC 
Created attachment 233831 [details] [review]
configure.ac: Rearrange pkg-config checks
Comment 6 Jasper St. Pierre (not reading bugmail) 2013-01-19 04:33:11 UTC 
Created attachment 233832 [details] [review]
configure.ac: Remove deprecated macro

AM_PROG_CC_C_O has been deprecated upstream for some time now.

As a side effect, this makes "git grep taskpanel" turn up blank!
Comment 7 Giovanni Campagna 2013-01-19 15:21:00 UTC 
Review of attachment 233827 [details] [review]:

This changes the warning flags at the same level, but I guess it's ok.
Comment 8 Giovanni Campagna 2013-01-19 15:21:51 UTC 
Review of attachment 233828 [details] [review]:

Yes.
(But if you wait, soon you'll be able to remove the check for XFixesCreatePointerBarrier too)
Comment 9 Giovanni Campagna 2013-01-19 15:22:36 UTC 
Review of attachment 233829 [details] [review]:

Wrong, this is used by data/Makefile.am
Comment 10 Giovanni Campagna 2013-01-19 15:22:56 UTC 
Review of attachment 233830 [details] [review]:

Yes.
Comment 11 Giovanni Campagna 2013-01-19 15:23:31 UTC 
Review of attachment 233831 [details] [review]:

Ok
Comment 12 Giovanni Campagna 2013-01-19 15:23:48 UTC 
Review of attachment 233832 [details] [review]:

Asd, yes.
Comment 13 Jasper St. Pierre (not reading bugmail) 2013-01-19 18:39:24 UTC 
Attachment 233827 [details] pushed as 3b57812 - configure.ac: Use GNOME_COMPILE_WARNINGS
Attachment 233828 [details] pushed as 685a9f3 - configure.ac: Remove checks for JS_NewGlobalObject
Attachment 233830 [details] pushed as 15b3318 - configure.ac: Remove old introspection infrastructure
Attachment 233831 [details] pushed as 420f544 - configure.ac: Rearrange pkg-config checks
Attachment 233832 [details] pushed as cdd3547 - configure.ac: Remove deprecated macro