After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 692032 - build: Add --disable-segv-handler option
build: Add --disable-segv-handler option
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: API
unspecified
Other Linux
: Normal normal
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-01-18 19:49 UTC by Colin Walters
Modified: 2013-01-22 17:50 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
0001-build-Add-disable-segv-handler-option.patch (2.61 KB, patch)
2013-01-18 19:49 UTC, Colin Walters 		none Details | Review
0001-Remove-SIGSEGV-SIGFPE-etc.-handling.patch (9.91 KB, patch)
2013-01-19 13:55 UTC, Colin Walters 		committed Details | Review

Description Colin Walters 2013-01-18 19:49:12 UTC 
Modern operating systems come with systemwide "crash catching"
    facilities; for example, the Linux kernel can now pipe core
    dumps out to userspace, and programs like "systemd-coredump"
    and "abrt" record these.
    
    In this model, it's actively counterproductive for individual
    processes to catch SIGSEGV because:
    
    1) Trying to unwind from inside the process after arbitrary
       corruption is destined to fail.
    2) It hides the fact that a crash happened at all - my OS test
       framework wants to know if any process crashed, and I don't
       want to guess by running regexps against /var/log/Xorg.0.log
       or whatever.
Comment 1 Colin Walters 2013-01-18 19:49:28 UTC 
Created attachment 233791 [details] [review]
0001-build-Add-disable-segv-handler-option.patch
Comment 2 Dan Winship 2013-01-18 21:05:07 UTC 
i'm not sure there's really any reason to make it configurable...
Comment 3 Colin Walters 2013-01-18 21:20:43 UTC 
(In reply to comment #2)
> i'm not sure there's really any reason to make it configurable...

I'm happy to prep a patch to delete it - even RHEL6 had abrt backported in 6.1, so there really aren't any relevant operating systems to which current NM git might possibly run that don't have crash catching in userspace.
Comment 4 Colin Walters 2013-01-19 13:55:20 UTC 
Created attachment 233865 [details] [review]
0001-Remove-SIGSEGV-SIGFPE-etc.-handling.patch
Comment 6 Dan Williams 2013-01-22 16:43:54 UTC 
Yes kill it.
Comment 7 Dan Williams 2013-01-22 16:44:15 UTC 
Review of attachment 233865 [details] [review]:

Good
Comment 8 Dan Winship 2013-01-22 17:50:53 UTC 
pushed