After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 692009 - text/css always formatted as attachment
text/css always formatted as attachment
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Mailer
3.6.x (obsolete)
Other Linux
: High normal
: ---
Assigned To: evolution-mail-maintainers
Evolution QA team
evolution[formatter]
Depends on:
Blocks:
 
 
Reported: 2013-01-18 13:25 UTC by Samarjit Adhikari
Modified: 2013-01-24 12:12 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
evo patch (1.53 KB, patch)
2013-01-21 12:18 UTC, Milan Crha
committed Details | Review
evo patch ][ (685 bytes, patch)
2013-01-21 18:07 UTC, Milan Crha
committed Details | Review
evo patch ]I[ (1.69 KB, patch)
2013-01-24 12:00 UTC, Milan Crha
committed Details | Review

Description Samarjit Adhikari 2013-01-18 13:25:19 UTC
Fedora-18
evolution 3.6.2.x 

@Milan
private data will be sent over personal e-mail.
Comment 1 André Klapper 2013-01-18 18:57:34 UTC
Thanks for taking the time to report this bug.
This bug report isn't very useful because it doesn't describe the bug well. 
Evolution in general is able to show images in emails. Also, you filed this against "evolution-mapi". 
If you have time and can still reproduce the bug, please read http://bugzilla.gnome.org/bug-HOWTO.html and add a more useful description to this bug.
Comment 2 Samarjit Adhikari 2013-01-19 03:10:29 UTC
(In reply to comment #1)
> Thanks for taking the time to report this bug.
> This bug report isn't very useful because it doesn't describe the bug well. 
> Evolution in general is able to show images in emails. Also, you filed this
> against "evolution-mapi". 
> If you have time and can still reproduce the bug, please read
> http://bugzilla.gnome.org/bug-HOWTO.html and add a more useful description to
> this bug.

I do understand that there is not enough info added in this bug report, but the issue is i cannot add my private information here. If you want i can send to you over your personal email.
Comment 3 André Klapper 2013-01-19 10:08:55 UTC
Thanks for the private email and the attachments.

Evolution 3.6 should render received mail using WebKit/GTK+ so this should be shown with CSS.

Maybe this is related to:
<script type="text/javascript" src="../../../include/base.js"></script>
<script type="text/javascript" src="../../../include/tooltip2.js"></script>
<script type="text/javascript" src="../../../include/jquery.js"></script>
<script type="text/javascript" src="../../../include/quixy_jquery.js"></script>

We do not execute scripts for security reasons.
Comment 4 Samarjit Adhikari 2013-01-19 11:35:57 UTC
(In reply to comment #3)
> Thanks for the private email and the attachments.
> 
> Evolution 3.6 should render received mail using WebKit/GTK+ so this should be
> shown with CSS.
> 
> Maybe this is related to:
> <script type="text/javascript" src="../../../include/base.js"></script>
> <script type="text/javascript" src="../../../include/tooltip2.js"></script>
> <script type="text/javascript" src="../../../include/jquery.js"></script>
> <script type="text/javascript" src="../../../include/quixy_jquery.js"></script>
> 
> We do not execute scripts for security reasons.

If it is specific to execution of java script why do not you provide an configurable option so that user can executes those scripts by choice?
Comment 5 Samarjit Adhikari 2013-01-19 11:41:43 UTC
(In reply to comment #3)
> Thanks for the private email and the attachments.
> 
> Evolution 3.6 should render received mail using WebKit/GTK+ so this should be
> shown with CSS.
> 
> Maybe this is related to:
> <script type="text/javascript" src="../../../include/base.js"></script>
> <script type="text/javascript" src="../../../include/tooltip2.js"></script>
> <script type="text/javascript" src="../../../include/jquery.js"></script>
> <script type="text/javascript" src="../../../include/quixy_jquery.js"></script>
> 
> We do not execute scripts for security reasons.

I checked those scripts. It has nothing to do with showing colour and image.
Those scripts will help in showing some action like tooltip etc.
Comment 6 Samarjit Adhikari 2013-01-19 16:53:01 UTC
(In reply to comment #3)
> Thanks for the private email and the attachments.
> 
> Evolution 3.6 should render received mail using WebKit/GTK+ so this should be
> shown with CSS.
> 
> Maybe this is related to:
> <script type="text/javascript" src="../../../include/base.js"></script>
> <script type="text/javascript" src="../../../include/tooltip2.js"></script>
> <script type="text/javascript" src="../../../include/jquery.js"></script>
> <script type="text/javascript" src="../../../include/quixy_jquery.js"></script>
> 
> We do not execute scripts for security reasons.

Moreover you will find those scripts only in thunderbird output(ews) not MAPI . I am using evolution-mapi. The same message should be represented in same way both in evolution-mapi and thunderbird. I believe there should be some issue in building the message in evolution-mapi.
Comment 7 Samarjit Adhikari 2013-01-20 04:09:44 UTC
> Moreover you will find those scripts only in thunderbird output(ews) not MAPI .
> I am using evolution-mapi. The same message should be represented in same way
> both in evolution-mapi and thunderbird. I believe there should be some issue in
> building the message in evolution-mapi.

In the following example <div class="lightred"> is not properly rendered by evolution whereas thunderbird does.

<!-- NUM=1 COMMENT= -->
<tr issueid="QCIM1B111414" class="odd" style="height:1px;vertical-align:top;">
  <td fieldName="NUM"><a name="1"></a>1
  <td fieldName="ISSUEID"><a href="http://quixy.deu.hp.com/quixy/query/detail.php?ISSUEID=QCIM1B111414">QCIM1B111414</a>
  <td fieldName="ICON"><div class="" trigger="popup"><a href="testdirector:qc2d.atlanta.hp.com/qcbin,BTO,NMC,[AnyUser];2:111414" target="_top"><img src="cid:6178a720742de2746280795148fe21afphone.png" border="0"></a></div>
  <td fieldName="AGE_TO_TERMINAL_STATE" trigger="popup"><div class="lightred">1</div>
Comment 8 Milan Crha 2013-01-21 12:11:44 UTC
I can confirm this, I see it with Samarjit's test message too.
Comment 9 Milan Crha 2013-01-21 12:18:34 UTC
Created attachment 234003 [details] [review]
evo patch

for evolution;

After some digging and looking into the code, I realized that the mail request always formatted the text/css as attachment, regardless the request to format it as RAW content, when it was referenced by its Content-Id inside the HTML body. This patch formats the text/*, except of text/plain and text/html parts, as raw data if requested, thus they are returned as expected.
Comment 10 Milan Crha 2013-01-21 12:26:36 UTC
Created commit 43911af in evo master (3.7.5+)
Created commit bfdec1f in evo gnome-3-6 (3.6.3+)
Comment 11 Milan Crha 2013-01-21 18:07:19 UTC
Created attachment 234036 [details] [review]
evo patch ][

for evolution;

Oops, a follow-up fix, meeting invites were not formatted properly with the above patch. This one fixes it.
Comment 12 Milan Crha 2013-01-21 18:11:08 UTC
Created commit dde7200 in evo master (3.7.5+)
Created commit bb2c283 in evo gnome-3-6 (3.6.3+)
Comment 13 Samarjit Adhikari 2013-01-22 04:42:32 UTC
(In reply to comment #12)
> Created commit dde7200 in evo master (3.7.5+)
> Created commit bb2c283 in evo gnome-3-6 (3.6.3+)

Can i get temporary build for this bug fix?
Comment 14 Milan Crha 2013-01-22 11:35:39 UTC
3.6.3 is out, I'm currently building it in koji and it will reach the updates-testing in a few days (will be there today, but it takes some time till the change is propagated to the repository).
Comment 15 Milan Crha 2013-01-24 09:55:29 UTC
Hrm, the change has regression, as reported in downstream bug report:
https://bugzilla.redhat.com/show_bug.cgi?id=903469

Description of problem:
Just sent out a patch (i.e. .patch), which is a plain Unix (LF) text file. Went to sent and used internal viewer to see the file. It renders it as if it was non-plain text (i.e. all spaces and tabs are hosed, font is not monospaced etc.).

Version-Release number of selected component (if applicable):
evolution-3.6.3-1.fc18.i686

How reproducible:
Always.

Steps to Reproduce:
1. Create a patch (e.g. svn diff > example.patch).
2. Send yourself an e-mail with that patch attached.
3. Use internal Evo viewer to see that file in sent.
  
Actual results:
File view jumbled (i.e. non-plain text).

Expected results:
Worked in F-17.

Additional info:
Problem with both IMAP+ and EWS, if it matters (probably not).
Comment 16 Milan Crha 2013-01-24 12:00:15 UTC
Created attachment 234298 [details] [review]
evo patch ]I[

for evolution;

OK, let's do an explicit request for CID references. I tested this with more messages than before, and all those seem fine, the patch is formatted as patch, a text/other-that-one-of-those-named is also formatted properly, same as the text/css references in an HTML part and meeting invitations.

I'm sorry for a brain-dead patches being used above. I'll also roll out a 3.6.3-2 release for Fedora 18 with this included.
Comment 17 Milan Crha 2013-01-24 12:12:31 UTC
Created commit f3dfdae in evo master (3.7.5+)
Created commit d25c6ff in evo gnome-3-6 (3.6.4+)