After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 691996 - lang: Remove use of __{define,lookup}{Getter,Setter}__
lang: Remove use of __{define,lookup}{Getter,Setter}__
Status: RESOLVED FIXED
Product: gjs
Classification: Bindings
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gjs-maint
gjs-maint
Depends on:
Blocks:
 
 
Reported: 2013-01-18 05:58 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2013-01-18 18:05 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
lang: Remove use of __{define,lookup}{Getter,Setter}__ (1.91 KB, patch)
2013-01-18 05:58 UTC, Jasper St. Pierre (not reading bugmail)
committed Details | Review

Description Jasper St. Pierre (not reading bugmail) 2013-01-18 05:58:34 UTC
Upstream is planning to remove all four of these methods -- they're
implementable in ECMAScript 5, along with more, so simply use those
instead of the SpiderMonkey special-cases.
Comment 1 Jasper St. Pierre (not reading bugmail) 2013-01-18 05:58:35 UTC
Created attachment 233725 [details] [review]
lang: Remove use of __{define,lookup}{Getter,Setter}__
Comment 2 Colin Walters 2013-01-18 13:12:39 UTC
Review of attachment 233725 [details] [review]:

Makes sense.
Comment 3 Jasper St. Pierre (not reading bugmail) 2013-01-18 18:05:07 UTC
Attachment 233725 [details] pushed as 3c6c3e0 - lang: Remove use of __{define,lookup}{Getter,Setter}__