After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 691990 - missing va_end(ap) at array_prop() in eggsmclient-xsmp.c
missing va_end(ap) at array_prop() in eggsmclient-xsmp.c
Status: RESOLVED FIXED
Product: libegg
Classification: Other
Component: other
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Libegg maintenance
Libegg maintenance
Depends on:
Blocks:
 
 
Reported: 2013-01-18 03:12 UTC by Akira TAGOH
Modified: 2016-12-16 20:16 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
eggsmclient-xsmp: Finalize variable arguments (765 bytes, patch)
2013-01-18 03:15 UTC, Akira TAGOH
none Details | Review

Description Akira TAGOH 2013-01-18 03:12:10 UTC
The summary says it all, array_pop() takes variable arguments and getting out of it with va_arg after va_start. but it isn't finalizing with va_end.
Comment 1 Akira TAGOH 2013-01-18 03:15:59 UTC
Created attachment 233712 [details] [review]
eggsmclient-xsmp: Finalize variable arguments
Comment 2 Murray Cumming 2016-12-16 20:16:47 UTC
I just happened to notice this bug reports after looking at libegg. I've pushed it, though I'm not the maintainer. But neither is anybody else, and this part of libegg doesn't build now anyway.