After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 691915 - sharing: add a 'show password' checkbox
sharing: add a 'show password' checkbox
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Sharing
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-01-17 04:05 UTC by Matthias Clasen
Modified: 2013-01-23 10:33 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
sharing: add a "show password" check button to the screen sharing dialog (5.73 KB, patch)
2013-01-22 11:26 UTC, Thomas Wood 		needs-work Details | Review

Description Matthias Clasen 2013-01-17 04:05:44 UTC 
The personal file sharing popup has a password entry without such a checkbox.
I think every password entry should have one.
Comment 1 Matthias Clasen 2013-01-17 04:07:13 UTC 
The same goes for the screen sharing popup.
Comment 2 Thomas Wood 2013-01-21 16:03:46 UTC 
The file sharing password is stored as a has so can't be retrieved for display, so it wouldn't be possible to add a "show password" checkbox for this option.

However, the screen sharing dialog should be able to have a "show password" checkbox.
Comment 3 Thomas Wood 2013-01-22 11:26:48 UTC 
Created attachment 234096 [details] [review]
sharing: add a "show password" check button to the screen sharing dialog
Comment 4 Bastien Nocera 2013-01-23 10:09:44 UTC 
Review of attachment 234096 [details] [review]:

::: panels/sharing/cc-sharing-panel.c
@@ +699,3 @@
                                 vino_get_password, vino_set_password, NULL, NULL);
+
+  g_signal_connect (WID ("show-password-checkbutton"), "toggled",

g_object_bind_property()?
Comment 5 Thomas Wood 2013-01-23 10:33:17 UTC 
Comment on attachment 234096 [details] [review]
sharing: add a "show password" check button to the screen sharing dialog

Commit 542db2b pushed with the change suggested above.