After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 691881 - Convert OpenCV to CV 2.3.1 and update corresponding code
Convert OpenCV to CV 2.3.1 and update corresponding code
Status: RESOLVED FIXED
Product: mousetrap
Classification: Other
Component: General
unspecified
Other Linux
: Normal normal
: ---
Assigned To: mousetrap-maint
mousetrap-maint
Depends on:
Blocks:
 
 
Reported: 2013-01-16 17:59 UTC by Logan H
Modified: 2014-01-31 18:30 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Replaced remaining cv code with cv2 (49.10 KB, patch)
2013-12-23 01:06 UTC, Logan H
needs-work Details | Review
Updated cv to cv2 (24.50 KB, patch)
2014-01-23 00:15 UTC, Logan H
accepted-commit_now Details | Review

Description Logan H 2013-01-16 17:59:46 UTC
Convert python-opencv code to CV 2.3.1
Comment 1 Logan H 2013-02-08 18:02:18 UTC
When this version is updated, we need to update the install directions
Comment 2 Logan H 2013-12-23 01:06:43 UTC
Created attachment 264776 [details] [review]
Replaced remaining cv code with cv2

Replaced remaining cv code w/ cv2 code.
Comment 3 Kevin Brown 2014-01-11 20:52:08 UTC
Review of attachment 264776 [details] [review]:

The *.rej files shouldn't be in this patch, as they were likely generated from a failed `git apply`.

The code appears to work as expected, but it could use some cleaning up.  There is quite a bit of dead code, along with some stray print statements, that should probably be removed before it is applied to the branch.

::: src/mousetrap/ocvfw/_ocv.py
@@ +158,3 @@
         self.grey = numpy.asarray(self.grey[:,:])        #new
 
+        #print "set-current", self.img_lkpoints["current"]

This (and the other commented out print statements) should probably be removed.
Comment 4 Logan H 2014-01-23 00:15:50 UTC
Created attachment 267006 [details] [review]
Updated cv to cv2

This is a cleaner version of my previous patch.
Comment 5 Kevin Brown 2014-01-29 00:37:35 UTC
Review of attachment 267006 [details] [review]:

Everything looks good as it stands.