GNOME Bugzilla – Bug 691881
Convert OpenCV to CV 2.3.1 and update corresponding code
Last modified: 2014-01-31 18:30:29 UTC
Convert python-opencv code to CV 2.3.1
When this version is updated, we need to update the install directions
Created attachment 264776 [details] [review] Replaced remaining cv code with cv2 Replaced remaining cv code w/ cv2 code.
Review of attachment 264776 [details] [review]: The *.rej files shouldn't be in this patch, as they were likely generated from a failed `git apply`. The code appears to work as expected, but it could use some cleaning up. There is quite a bit of dead code, along with some stray print statements, that should probably be removed before it is applied to the branch. ::: src/mousetrap/ocvfw/_ocv.py @@ +158,3 @@ self.grey = numpy.asarray(self.grey[:,:]) #new + #print "set-current", self.img_lkpoints["current"] This (and the other commented out print statements) should probably be removed.
Created attachment 267006 [details] [review] Updated cv to cv2 This is a cleaner version of my previous patch.
Review of attachment 267006 [details] [review]: Everything looks good as it stands.
Bug fixed with commit: https://git.gnome.org/browse/mousetrap/commit/?h=gnome3-wip&id=eb4e482c553c9fd13ec57fab924c7c64304339be