After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 691879 - Convert to Gtk+ 3 and GObject Introspection
Convert to Gtk+ 3 and GObject Introspection
Status: RESOLVED FIXED
Product: mousetrap
Classification: Other
Component: General
unspecified
Other Linux
: Normal normal
: ---
Assigned To: mousetrap-maint
mousetrap-maint
Depends on:
Blocks:
 
 
Reported: 2013-01-16 17:56 UTC by Joanmarie Diggs (IRC: joanie)
Modified: 2014-03-03 15:02 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Clean up after the GTK 3 transition (37.92 KB, patch)
2014-03-02 22:08 UTC, Kevin Brown
committed Details | Review

Description Joanmarie Diggs (IRC: joanie) 2013-01-16 17:56:46 UTC
Mousetrap is still Gtk+ 2 and pygi-based. That's not GNOME 3 good citizenry.
Comment 1 Kevin Brown 2014-02-28 15:19:24 UTC
I think a patch may have already landed that fixes this in d326ff67 [1].  This needs to be checked and closed if only the one commit was needed for the conversion.

[1]: https://git.gnome.org/browse/mousetrap/commit/?h=gnome3-wip&id=d326ff6884f683e3b4248c581c02f9b9765cb52f
Comment 2 Kevin Brown 2014-03-02 22:08:22 UTC
Created attachment 270729 [details] [review]
Clean up after the GTK 3 transition

This cleans up some of the code that was introduced as a result of the first commit [1].

It's a squashed version of a commit set [2] that removes much of the dead code sitting around the affected areas.  It also switches the calls to `GObject.__init__` to use `super`, which will also call `__init__` on any of the superclasses instead of specifically on `GObject`.  This will still work it's way up to `GObject`, which is almost always in the chain.

[1]: https://git.gnome.org/browse/mousetrap/commit/?h=gnome3-wip&id=d326ff6884f683e3b4248c581c02f9b9765cb52f
[2]: https://github.com/kevin-brown/mousetrap/compare/cb21fd55...issue_69187