After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 691877 - Gdm must enable the keyboard plugin in gnome-settings-daemon
Gdm must enable the keyboard plugin in gnome-settings-daemon
Status: RESOLVED FIXED
Product: gdm
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GDM maintainers
GDM maintainers
Depends on:
Blocks:
 
 
Reported: 2013-01-16 17:46 UTC by Giovanni Campagna
Modified: 2013-01-21 18:39 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Enable keyboard plugin in the login session (1.09 KB, patch)
2013-01-17 23:34 UTC, Matthias Clasen
committed Details | Review
Lock down the hotplug-command key (1.18 KB, patch)
2013-01-19 02:07 UTC, Matthias Clasen
committed Details | Review

Description Giovanni Campagna 2013-01-16 17:46:33 UTC
Otherwise layout switching doesn't work in gnome-initial-setup (which uses the same dconf profile as the greeter), and the whole keyboard setup page has no effect.
Comment 1 Matthias Clasen 2013-01-17 23:34:21 UTC
Created attachment 233704 [details] [review]
Enable keyboard plugin in the login session

This is necessary for the keyboard page in gnome-initial-setup
to work.
Comment 2 Ray Strode [halfline] 2013-01-18 18:07:41 UTC
I'm okay with this as long as someone has read through the keyboard plugin and made sure it's "safe" to load at the login screen.

I mean we just need to make sure it doesn't provide some hotkey for showing ibus config panels with that let you start terminals when hitting some cheat code of modifiers or something crazy like that.
Comment 3 Matthias Clasen 2013-01-19 02:00:34 UTC
I've looked over the keyboard plugin. Here is what it does:

1) launch /usr/libexec/gsd-input-sources-switcher when needed

2) activate ibus-daemon when needed

3) on device plugin/out, run a custom command specified by org.gnome.settings-daemon.peripherals.input-devices hotplug-command

In maybe_create_input_sources(), there is already code that looks at the  RUNNING_UNDER_GDM env var and only uses the current xkb config instead of stored configuration. This also means that ibus is not activated.

We need to lock down the hotplug-command setting in the gdm dconf profile.
Comment 4 Matthias Clasen 2013-01-19 02:07:00 UTC
Created attachment 233823 [details] [review]
Lock down the hotplug-command key

This key specifies a script to be run when a device is
plugged in. We don't want that to happen on the login screen.
Comment 5 Matthias Clasen 2013-01-21 18:39:08 UTC
Attachment 233704 [details] pushed as eeb4f21 - Enable keyboard plugin in the login session
Attachment 233823 [details] pushed as 305df4a - Lock down the hotplug-command key