After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 691875 - screenshot: Immediately show the flash spot
screenshot: Immediately show the flash spot
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-01-16 17:13 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2013-01-16 22:20 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
screenshot: Immediately show the flash spot (1.57 KB, patch)
2013-01-16 17:13 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review

Description Jasper St. Pierre (not reading bugmail) 2013-01-16 17:13:10 UTC 
The "flash" effect looks awkward when it fades in and out. Real
camera have an immediate flash of light, which then seems to fade
out as our eyes readjust the rapid change in lighting.
Comment 1 Jasper St. Pierre (not reading bugmail) 2013-01-16 17:13:13 UTC 
Created attachment 233614 [details] [review]
screenshot: Immediately show the flash spot
Comment 2 Cosimo Cecchi 2013-01-16 17:31:51 UTC 
Review of attachment 233614 [details] [review]:

I think it's an improvement, but trying it out I think it needs a few other tweaks:
- the timing needs to be increased a bit, since we're now doing only one animation
- the easing function shouldn't be linear anymore

I found the settings I like most are using easeInQuad with a timing of 0.30.

::: js/ui/screenshot.js
@@ +263,3 @@
         Tweener.addTween(this.actor,
                          { opacity: 0,
+                           time: FLASHSPOT_ANIMATION_OUT_TIME,

The constant itself also needs to be renamed
Comment 3 Jasper St. Pierre (not reading bugmail) 2013-01-16 22:20:03 UTC 
Attachment 233614 [details] pushed as 90fae00 - screenshot: Immediately show the flash spot


Cosimo and I worked out some settings we both liked on IRC.