After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 691778 - Provide more information about the 'FAILED' state of a modem
Provide more information about the 'FAILED' state of a modem
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: ModemManager
git master
Other Linux
: Normal normal
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-01-15 10:38 UTC by Aleksander Morgado
Modified: 2013-03-12 19:17 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Aleksander Morgado 2013-01-15 10:38:30 UTC
Modems in 'failed' state aren't really shown in the UIs right now, as the user cannot do anything with them. A good approach, though, would be to show them in the UI but stating the reason why they went into failed state.

One approach would be to use new more specific 'failed' state values to handle this, e.g.:
   MM_MODEM_STATE_FAILED_AIRPLANE_MODE = -5
   MM_MODEM_STATE_FAILED_SIM_MISSING   = -4
   MM_MODEM_STATE_FAILED_SIM_LOCKED    = -3
   MM_MODEM_STATE_FAILED_SIM_ERROR     = -2
   MM_MODEM_STATE_FAILED               = -1

The problem with this approach is that the 'state' enum is used in lots of places, and we don't really want to get forced to modify lots of code just to handle this.

Another approach would be to have a 'FailureReason' property in the Modem interface, which will contain the reason for the failure only if the state == failed.
Comment 1 Marius Kotsbak 2013-02-03 20:03:21 UTC
The second options sounds best. Is it then just to update the clients to display failed modems too, with a message describing why?
Comment 2 Aleksander Morgado 2013-02-22 08:01:09 UTC
Implemented in the 'state-failed-reason' branch in upstream git:

http://cgit.freedesktop.org/ModemManager/ModemManager/commit/?h=state-failed-reason&id=1cc6c9800fb48ed61d134df5592b2ea970774e47

Comments welcome.
Comment 3 Aleksander Morgado 2013-03-12 17:40:07 UTC
This branch was merged to git master not long ago.
Comment 4 Marius Kotsbak 2013-03-12 19:11:20 UTC
Then see bug #559488.
Comment 5 Marius Kotsbak 2013-03-12 19:17:40 UTC
Probably fixed in commit 75d20c15d4f844270cfc6c31fae261412e4b1b59 and friends, not yet in any release.