After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 691775 - master fails to build: tester.h:483:57: error: expected ',' or ';' before 'extern'
master fails to build: tester.h:483:57: error: expected ',' or ';' before 'ex...
Status: RESOLVED FIXED
Product: gtk-doc
Classification: Platform
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtk-doc maintainers
gtk-doc maintainers
Depends on:
Blocks:
 
 
Reported: 2013-01-15 09:59 UTC by Martin Pitt
Modified: 2013-01-15 14:40 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Use GLIB_DEPRECATED as a prefix (837 bytes, patch)
2013-01-15 10:19 UTC, Martin Pitt 		committed Details | Review

Description Martin Pitt 2013-01-15 09:59:30 UTC 
A few days ago, jhbuild build has started breaking very early on building gtk-doc:

  GEN    .gitignore
In file included from tester.c:23:0:
tester.h:483:57: error: expected ',' or ';' before 'extern'
make[3]: *** [tester.lo] Error 1

This is the following line in tester.h:

void bug_624001e (void) GLIB_DEPRECATED;

which with gcc -E expands to

void bug_624001e (void) __attribute__((__deprecated__)) extern;

I'm not sure why GLIB_DEPRECATED expands to "extern", but glib's own headers use it as a prefix, e. g. in /glib/gstrfuncs.h:

LIB_DEPRECATED
gint                  g_strcasecmp     (const gchar *s1,
                                        const gchar *s2);
Comment 1 Martin Pitt 2013-01-15 10:19:53 UTC 
Created attachment 233512 [details] [review]
Use GLIB_DEPRECATED as a prefix

With this, gtk-doc builds fine again.

Thanks for considering!
Comment 2 Allison Karlitskaya (desrt) 2013-01-15 14:33:59 UTC 
Review of attachment 233512 [details] [review]:

Since GLIB_DEPRECATED is a for-GLIB-use-only thing, it's sort of annoying to see it in another module...

Meanwhile, I guess it's just a testcase, so that's fine.

Please push :)
Comment 3 Martin Pitt 2013-01-15 14:40:05 UTC 
Pushed, thanks!