After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 691769 - Build of glib-genmarshal broke on Windows/Visual C++ builds
Build of glib-genmarshal broke on Windows/Visual C++ builds
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gobject
unspecified
Other Windows
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2013-01-15 07:55 UTC by Fan, Chun-wei
Modified: 2013-01-15 11:38 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Revert commit f2e00a07 due to missed check of G_OS_WIN32 (1.06 KB, patch)
2013-01-15 07:55 UTC, Fan, Chun-wei 		committed Details | Review

Description Fan, Chun-wei 2013-01-15 07:55:08 UTC 
Created attachment 233502 [details] [review]
Revert commit f2e00a07 due to missed check of G_OS_WIN32

Hi, it seems that commit f2e00a07 broke the build of glib-genmarshal.c on Visual C++ builds as the check of G_OS_WIN32 was done before including any of the GLib headers (The GLib headers define that macro), so that io.h was not included as it should have been.

The attached revert patch attempts to fix this issue.

With blessings, thank you!
Comment 1 Matthias Clasen 2013-01-15 11:16:45 UTC 
Review of attachment 233502 [details] [review]:

ok
Comment 2 Fan, Chun-wei 2013-01-15 11:37:57 UTC 
Review of attachment 233502 [details] [review]:

Committed as 38229d47.  Will close this shortly.

With blessings, thank you! :)