After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 691766 - Incorrect remote hostname
Incorrect remote hostname
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Sharing
3.7.x
Other Linux
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
3.10
Depends on:
Blocks:
 
 
Reported: 2013-01-15 07:50 UTC by Bastien Nocera
Modified: 2013-06-13 12:57 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
sharing: retrieve the mDNS hostname from Avahi, if available (6.10 KB, patch)
2013-06-13 10:56 UTC, Thomas Wood 		committed Details | Review

Description Bastien Nocera 2013-01-15 07:50:18 UTC 
My machine's hostname is "novo". This isn't a remotely accessible name.

Vino's properties used to get the remotely accessible name from the router via upnp, which is one possibility. Otherwise, append ".local" to the short hostname (novo.local is handled as long as nss-mdns is installed).
Comment 1 Thomas Wood 2013-06-13 10:56:37 UTC 
Created attachment 246712 [details] [review]
sharing: retrieve the mDNS hostname from Avahi, if available
Comment 2 Bastien Nocera 2013-06-13 12:18:04 UTC 
Review of attachment 246712 [details] [review]:

Looks good otherwise.

::: panels/sharing/cc-sharing-panel.c
@@ +619,3 @@
+  variant = g_dbus_connection_call_finish (connection, res, &error);
+
+  if (error)

if (variant == NULL)

@@ +659,3 @@
+  connection = g_bus_get_finish (res, &error);
+
+  if (error)

if (connection == NULL)
Comment 3 Thomas Wood 2013-06-13 12:57:12 UTC 
Attachment 246712 [details] pushed as 16a6789 - sharing: retrieve the mDNS hostname from Avahi, if available