GNOME Bugzilla – Bug 691763
Text field shouldn't be selected by default
Last modified: 2013-01-29 16:24:00 UTC
Makes it too easy to change the machine's name. Perhaps it should be behind a button (similarly to the user name in the user accounts panel for example).
Created attachment 234029 [details] [review] sharing: avoid focusing the CcHostnameEntry widget when the panel is shown
Review of attachment 234029 [details] [review]: This patch fixes the primary issue at least until further design review can be done.
Review of attachment 234029 [details] [review]: I don't really like focus hacks like this one, and I would really rather we looked into using the button/entry combo used in the user accounts.
The original design was from Jon McCann, so adding him to CC for comment.
Another way to deal with this would be to look in the focus chain, and focus the next item in line.
Created attachment 234423 [details] [review] sharing: avoid focusing the CcHostnameEntry widget when the panel is shown Alternative patch to focus the main list box (which is the next item in the focus chain). Specifying the list box directly should probably result in more consistent behaviour.
Review of attachment 234423 [details] [review]: ::: panels/sharing/cc-sharing-panel.c @@ +773,3 @@ + + g_signal_connect_swapped (self, "map", G_CALLBACK (gtk_widget_grab_focus), + WID ("main-list-box")); Should select a focusable widget instead.
(In reply to comment #7) > Review of attachment 234423 [details] [review]: > > ::: panels/sharing/cc-sharing-panel.c > @@ +773,3 @@ > + > + g_signal_connect_swapped (self, "map", G_CALLBACK (gtk_widget_grab_focus), > + WID ("main-list-box")); > > Should select a focusable widget instead. The EggListBox is the only focusable widget in this case (the children are just containers with labels).
Attachment 234423 [details] pushed as b22c18e - sharing: avoid focusing the CcHostnameEntry widget when the panel is shown