After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 691750 - search provider crashes search in gnome-shell
search provider crashes search in gnome-shell
Product: gnome-shell
Classification: Core
Component: general
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
Depends on:
Reported: 2013-01-15 00:01 UTC by Volker Sobek (weld)
Modified: 2013-01-15 00:44 UTC
See Also:
GNOME target: ---
GNOME version: ---

remoteSearch: fix a typo in createIcon (988 bytes, patch)
2013-01-15 00:37 UTC, Cosimo Cecchi
committed Details | Review

Description Volker Sobek (weld) 2013-01-15 00:01:16 UTC
When I just type 'e' in the gnome-shell search, a few results pop up for a second and then they all disappear again, leaving me with an empty results page. I disabled a few search providers in the control center and found that this only happens when gnome-document is enabled as a search provider.

When I press 'e' in the shell overview (gnome-documents search enabled), session.log says:
    JS ERROR: !!!   Exception was: Error: Expected type utf8 for Argument 'str' but got type 'undefined' (nil)
    JS ERROR: !!!     message = '"Expected type utf8 for Argument 'str' but got type 'undefined' (nil)"'
    JS ERROR: !!!     fileName = '"/home/gnomedev/jhbuild-gnome/install/3.8/share/gnome-shell/js/ui/remoteSearch.js"'
    JS ERROR: !!!     lineNumber = '202'
    JS ERROR: !!!     stack = '"(64,[object Object])@/home/gnomedev/jhbuild-gnome/install/3.8/share/gnome-shell/js/ui/remoteSearch.js:202
wrapper(64,[object Object])@/home/gnomedev/jhbuild-gnome/install/3.8/share/gjs-1.0/lang.js:204
([object Object],[object Object],[object Array])@/home/gnomedev/jhbuild-gnome/install/3.8/share/gnome-shell/js/ui/searchDisplay.js:68
wrapper([object Object],[object Object],[object Array])@/home/gnomedev/jhbuild-gnome/install/3.8/share/gjs-1.0/lang.js:204
([object Object],[object Object],[object Array])@/home/gnomedev/jhbuild-gnome/install/3.8/share/gjs-1.0/lang.js:145
([object Object],[object Object],[object Array])@/home/gnomedev/jhbuild-gnome/install/3.8/share/gjs-1.0/lang.js:239
([object Array])@/home/gnomedev/jhbuild-gnome/install/3.8/share/gnome-shell/js/ui/searchDisplay.js:213
wrapper([object Array])@/home/gnomedev/jhbuild-gnome/install/3.8/share/gjs-1.0/lang.js:204
([object Array])@/home/gnomedev/jhbuild-gnome/install/3.8/share/gnome-shell/js/ui/searchDisplay.js:488
([object Array],null,function () {[native code]})@/home/gnomedev/jhbuild-gnome/install/3.8/share/gnome-shell/js/ui/remoteSearch.js:253
wrapper([object Array],null,function () {[native code]})@/home/gnomedev/jhbuild-gnome/install/3.8/share/gjs-1.0/lang.js:204
([object Array],null)@/home/gnomedev/jhbuild-gnome/install/3.8/share/gjs-1.0/lang.js:116
([object GObject_Object],[object GObject_Object])@/home/gnomedev/jhbuild-gnome/install/3.8/share/gjs-1.0/overrides/Gio.js:91
Comment 1 Cosimo Cecchi 2013-01-15 00:37:30 UTC
-> gnome-shell

This is a regression from a recent gnome-shell commit.
Comment 2 Cosimo Cecchi 2013-01-15 00:37:59 UTC
Created attachment 233488 [details] [review]
remoteSearch: fix a typo in createIcon

428876123579589a228770faab57887169fea343 changed the method to always
create a GIcon, but didn't pass it down to the StIcon constructor.
Comment 3 Florian Müllner 2013-01-15 00:42:04 UTC
Review of attachment 233488 [details] [review]:

Comment 4 Cosimo Cecchi 2013-01-15 00:44:11 UTC
Attachment 233488 [details] pushed as 16a9391 - remoteSearch: fix a typo in createIcon